After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748348 - video-converter: change data type of _GstLineCache::n_lines
video-converter: change data type of _GstLineCache::n_lines
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-23 04:08 UTC by RaviKiran
Modified: 2015-04-23 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
make n_lines type as guint (877 bytes, patch)
2015-04-23 04:11 UTC, RaviKiran 		committed Details | Review

Description RaviKiran 2015-04-23 04:08:33 UTC 
Type of _GstLineCache::n_lines is gboolean. Change it to guint for readability.
Comment 1 RaviKiran 2015-04-23 04:11:03 UTC 
Created attachment 302194 [details] [review]
make n_lines type as guint

Patch attached, pls review
Comment 2 Tim-Philipp Müller 2015-04-23 12:39:44 UTC 
Thanks, pushed:

commit 0ff9b1e27663477c714bcbaa2bff6ab5a7575da2
Author: Ravi Kiran K N <ravi.kiran@samsung.com>
Date:   Thu Apr 23 09:50:12 2015 +0530

    video-converter: n_lines member should be a guint not a boolean
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748348


It's for "correctness" rather than readability really :)