After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748247 - oggdemux: fix event leak
oggdemux: fix event leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-21 13:24 UTC by Guillaume Desmottes
Modified: 2015-04-23 10:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
oggdemux: fix event leaks (2.18 KB, patch)
2015-04-21 13:30 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2015-04-21 13:24:44 UTC 
.
Comment 1 Guillaume Desmottes 2015-04-21 13:30:14 UTC 
Created attachment 302067 [details] [review]
oggdemux: fix event leaks

gst_event_replace() takes its own reference on the event so we should drop
ours after creating and storing an event using it.

This fix leaks which can be reproduced using the
validate.http.media_check.vorbis_theora_1_ogg scenario.
Comment 2 Vincent Penquerc'h 2015-04-23 10:04:15 UTC 
Thanks, pushed.

commit d31472fde750d3a592ef2232bfafe97dc34a9465
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Tue Apr 21 15:27:57 2015 +0200

    oggdemux: fix event leaks
    
    gst_event_replace() takes its own reference on the event so we should drop
    ours after creating and storing an event using it.
    
    This fix leaks which can be reproduced using the
    validate.http.media_check.vorbis_theora_1_ogg scenario.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748247