After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748231 - textoverlay: add minimal support for Closed Captions
textoverlay: add minimal support for Closed Captions
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.2.2
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-21 07:51 UTC by vishwanath
Modified: 2018-05-01 07:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
its an patch for gstbasetextoverlay.c (9.76 KB, patch)
2015-04-21 07:51 UTC, vishwanath 		none Details | Review
Header file incluing few more fields (195 bytes, patch)
2015-04-21 07:53 UTC, vishwanath 		none Details | Review

Description vishwanath 2015-04-21 07:51:23 UTC 
Created attachment 302048 [details] [review]
its an patch for gstbasetextoverlay.c

Three new Properties have been added to gstbasetextoverlay and corresponding operations, to provide closed caption support . A property cc(closed caption)to enable switch between closed caption mode and normal text-rendering mode.
A property bg-flag to select in CC mode you need Background or Outline.
A property background-color to set ARGB for background color . 

I have developed it over gst-plugins-base-1.2.2 .
Comment 1 vishwanath 2015-04-21 07:53:00 UTC 
Created attachment 302049 [details] [review]
Header file incluing few more fields
Comment 2 Nicolas Dufresne (ndufresne) 2015-07-28 16:29:11 UTC 
Any intention to rebase on git master ?
Comment 3 vishwanath patil 2015-07-29 12:22:11 UTC 
I will rebase it to latest commit . you want me to do it master branch latest commit right ?
Comment 4 Nicolas Dufresne (ndufresne) 2015-07-29 12:53:58 UTC 
(In reply to vishwanath patil from comment #3)
> I will rebase it to latest commit . you want me to do it master branch
> latest commit right ?

Yes please. I'm pinging here since I know we did quite some changes recently in the class. I think the feature you propose is worth it and would like to be able to review and merge it at some point. I might have discovered this bug too late for 1.6, but I'm keeping an eye on it now. Along with this, I think it's also wanted to implement the subtitle stacking, hence we might want to think of a common interface for configure these mode as they are mutually exclusive.
Comment 5 vishwanath patil 2015-07-31 09:26:55 UTC 
git rebase i am having problem stormer , i have patched it over latest master shall i share the same.
Comment 6 Nicolas Dufresne (ndufresne) 2015-07-31 12:38:17 UTC 
(In reply to vishwanath patil from comment #5)
> git rebase i am having problem stormer , i have patched it over latest
> master shall i share the same.

Well that's the reason I didn't do it myself ;-P Whatever it needs.
Comment 7 vishwanath patil 2015-07-31 12:48:00 UTC 
there is some common folder missing , it is giving problem with rebase.
Comment 8 Edward Hervey 2018-05-01 07:11:30 UTC 
The problem is not well defined. And there have been no answers in 3 years. Closing. Please re-open if you can define exactly what the intent of your patch is and can provide a patch against current GStreamer.