After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748120 - ctrl+a should change to selection mode
ctrl+a should change to selection mode
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.16.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-18 21:17 UTC by Pranav Kant
Modified: 2015-09-22 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
view: Change to selection mode when pressing ctrl+a (953 bytes, patch)
2015-09-09 14:20 UTC, Alessandro Bono 		none Details | Review
view: Change to selection mode when pressing ctrl+a (817 bytes, patch)
2015-09-18 17:17 UTC, Alessandro Bono 		committed Details | Review

Description Pranav Kant 2015-04-18 21:17:33 UTC 
Hitting ctrl+a, currently, selects all the items in the overview, but this is not noticeable to the user, unless he manually changes to selection mode.

It would be better to change the overview to selection mode as soon as user hits ctrl+a.
Comment 1 Alessandro Bono 2015-09-09 14:20:03 UTC 
Created attachment 310985 [details] [review]
view: Change to selection mode when pressing ctrl+a
Comment 2 Bastien Nocera 2015-09-18 16:34:38 UTC 
Review of attachment 310985 [details] [review]:

Looks correct to me.
Comment 3 Cosimo Cecchi 2015-09-18 17:03:55 UTC 
Review of attachment 310985 [details] [review]:

::: src/view.js
@@ +375,3 @@
+                let selectionMode = Application.selectionController.getSelectionMode();
+                if (!selectionMode)
+                    Application.selectionController.setSelectionMode(true);

You can call this function without checking the value of getSelectionMode(), because it will already short-circuit when the same value is set.
Comment 4 Alessandro Bono 2015-09-18 17:17:39 UTC 
Created attachment 311645 [details] [review]
view: Change to selection mode when pressing ctrl+a
Comment 5 Cosimo Cecchi 2015-09-18 17:18:52 UTC 
Review of attachment 311645 [details] [review]:

Looks good, thanks
Comment 6 Debarshi Ray 2015-09-22 19:19:35 UTC 
Comment on attachment 311645 [details] [review]
view: Change to selection mode when pressing ctrl+a

Pushed to master, gnome-3-16 and gnome-3-14.