After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748119 - GstMetaTransformFunction returns gboolean but its retval is discarded
GstMetaTransformFunction returns gboolean but its retval is discarded
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Mac OS
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-18 21:14 UTC by Ilya Konstantinov
Modified: 2015-04-20 07:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Ilya Konstantinov 2015-04-18 21:14:52 UTC 
In gstmeta.h:

/**
 ...
 * Returns: %TRUE if the transform could be performed
 */
typedef gboolean (*GstMetaTransformFunction) (GstBuffer *transbuf,
                                              GstMeta *meta, GstBuffer *buffer,
                                              GQuark type, gpointer data);

However, in gstbuffer.c:

  if (flags & GST_BUFFER_COPY_META) {
    ...
      if (info->transform_func) {
        ...
        info->transform_func (dest, meta, src,
            _gst_meta_transform_copy, &copy_data); // <-- retval unused
      }
  }
Comment 1 Sebastian Dröge (slomo) 2015-04-20 07:22:22 UTC 
More than this shouldn't be needed here. If it fails, the meta is just not copied.

commit a5ab02733a614a258e0effcdeb91968f4795cb7b
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Apr 20 09:23:43 2015 +0200

    buffer: Check return value of meta transform function in gst_buffer_copy_into()
    
    ... by printing some debug output whenever copying a GstMeta fails.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748119