After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747935 - vaapisink: use the GstVideoSink vmethod show_frame()
vaapisink: use the GstVideoSink vmethod show_frame()
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 743569
 
 
Reported: 2015-04-15 16:26 UTC by Víctor Manuel Jáquez Leal
Modified: 2015-04-16 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vaapisink: use the GstVideoSink vmethod show_frame() (3.05 KB, patch)
2015-04-15 16:26 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Víctor Manuel Jáquez Leal 2015-04-15 16:26:02 UTC 
Don't use the GstBaseSink vmethods render() and preroll(), but show_frame() in
GstVideoSink
Comment 1 Víctor Manuel Jáquez Leal 2015-04-15 16:26:06 UTC 
Created attachment 301661 [details] [review]
vaapisink: use the GstVideoSink vmethod show_frame()

vaapisink inherits from GstVideoSink, in order to use its functionality (such
as ::show-preroll-frame property), we should use its vmethod show_frame(),
rather than call ourselves render() and preroll().
Comment 2 Víctor Manuel Jáquez Leal 2015-04-16 09:47:15 UTC 
commit 504fdedf84cc356d002539abac0b263363c9d4a8
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Wed Apr 15 17:26:43 2015 +0200

    vaapisink: use GstVideoSink vmethod show_frame()
    
    vaapisink inherits from GstVideoSink, in order to use its functionality (such
    as ::show-preroll-frame property), we should use its vmethod show_frame(),
    rather than call ourselves render() and preroll().