GNOME Bugzilla – Bug 747845
rtpsource: Try to keep clock-rate and payload type updated for sender RTCP too
Last modified: 2015-04-20 07:06:12 UTC
See commit message. The only downside is now that we always call that for RTX streams, and before this we never emitted request-pt-map for senders. Only for receivers. So if someone implements RTX now and does not handle this, the signal will be emitted for every single packet that is sent. The alternative would be to always change the caps in rtxsend whenever it sends a RTX packet, and back to the other caps when it sends a normal packet. This fixes the "no clock-rate, cannot interpolate rtp time" warning in rtp_source_get_new_sr() for the RTX streams.
Created attachment 301528 [details] [review] rtpsource: Try to keep clock-rate and payload type updated for sender RTCP too For RTX we will get packets with different payload types, and only for the main stream we have the clock-rate and everything inside the caps. For the RTX stream we will have to ask. The clock-rate is later needed for properly creating sender reports.
Created attachment 301531 [details] [review] rtpsource: Try to keep clock-rate and payload type updated for sender RTCP too For RTX we will get packets with different payload types, and only for the main stream we have the clock-rate and everything inside the caps. For the RTX stream we will have to ask. The clock-rate is later needed for properly creating sender reports.
Created attachment 301532 [details] [review] rtprtxsend: Copy over timestamps from the orignal buffers to the RTX buffers
*** This bug has been marked as a duplicate of bug 747394 ***