After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747602 - basetextoverlay: Leak in gst_base_text_overlay_text_chain
basetextoverlay: Leak in gst_base_text_overlay_text_chain
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-10 06:53 UTC by Guillaume Desmottes
Modified: 2015-04-10 09:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
basetextoverlay: fix buffer leak in chain function (1.44 KB, patch)
2015-04-10 06:54 UTC, Guillaume Desmottes 		none Details | Review

Description Guillaume Desmottes 2015-04-10 06:53:11 UTC 
.
Comment 1 Guillaume Desmottes 2015-04-10 06:54:33 UTC 
Created attachment 301256 [details] [review]
basetextoverlay: fix buffer leak in chain function

If we don't consume the buffer by passing its reference to
overlay->text_buffer then we need to unref it.

Fix a leak with validate.file.playback.fast_forward.test5_mkv when running
inside Valgrind.

https://bugzilla.gnome.org/show_bug.cgi?id=747602

Signed-off-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Comment 2 Tim-Philipp Müller 2015-04-10 09:14:28 UTC 
Pushed, thanks:

commit e9a6cafa13eafdcd81abb767cf3e959c0ae918f4
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Apr 9 17:03:11 2015 +0200

    basetextoverlay: fix buffer leak in chain function
    
    If we don't consume the buffer by passing its reference to
    overlay->text_buffer then we need to unref it.
    
    Fix a leak with validate.file.playback.fast_forward.test5_mkv
    when running inside Valgrind.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=747602