After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747407 - Make indicators pop out when needed
Make indicators pop out when needed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkScrolledWindow
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-04-06 13:17 UTC by Matthias Clasen
Modified: 2015-04-06 23:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make indicators pop out when needed (1.25 KB, patch)
2015-04-06 13:18 UTC, Matthias Clasen
none Details | Review
Make indicators pop out when needed (1.65 KB, patch)
2015-04-06 13:29 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2015-04-06 13:17:57 UTC
When moving over a non-expanded indicator from the outside, we were
not expanding it, due to on_scrollbar being true. We must still
ensure that the indicator is expanded when receiving motion events
over the indicator.
Comment 1 Matthias Clasen 2015-04-06 13:18:00 UTC
Created attachment 301018 [details] [review]
Make indicators pop out when needed
Comment 2 Matthias Clasen 2015-04-06 13:29:33 UTC
Created attachment 301019 [details] [review]
Make indicators pop out when needed

When moving over a non-expanded indicator from the outside, we were
not expanding it, due to on_scrollbar being true. This can be seen
e.g. when moving from the content pane over to the sidebar indicator
in gtk3-demo. We must still ensure that the indicator is expanded
when receiving motion events over the indicator.
Comment 3 Carlos Garnacho 2015-04-06 14:29:14 UTC
Comment on attachment 301019 [details] [review]
Make indicators pop out when needed

Hmm indeed, I tried to cover leave events from the scrolledwindow child to the scrollbar later in that function, we could probably fold that together with the last else if() in the motion events branch if we're checking for motion events everywhere.
Comment 4 Matthias Clasen 2015-04-06 23:38:29 UTC
Attachment 301019 [details] pushed as cfb5f16 - Make indicators pop out when needed