GNOME Bugzilla – Bug 747400
Fix build on OpenBSD
Last modified: 2015-05-12 22:27:58 UTC
Created attachment 301003 [details] [review] allow building on OpenBSD Hi. Trivial diff that allows me to build gnome-builder on OpenBSD. Would it be alright if I pushed this? Thanks.
Review of attachment 301003 [details] [review]: LGTM, thanks!
Awesome, thanks Christian. It's in: 42a3d2a4ca6793d1ff8dd97914999921268c2667
We did a bunch of build cleanup in the last week or two, and I'd love to know if things are still working on OpenBSD. Any chance you can give it a shot?
(In reply to Christian Hergert from comment #3) > We did a bunch of build cleanup in the last week or two, and I'd love to > know if things are still working on OpenBSD. > > Any chance you can give it a shot? Hi Christian. I just built gnome-builder HEAD as of an hour ago on OpenBSD. The only issue I ran into is the unconditional passing of '-lrt': warning: could not find a rt library Link error: rt not found! librt does not exist on OpenBSD and is not needed, we don't need it to get sem_*, sched_* and friends. If you could add a configure check for it, then gnome-builder would build out-of-the-box. Thanks :-)
I simplified things to use atomics if we don't have rdtscp (since ensuring that sched_getcpu() is fast is difficult across all platforms anyway). Additionally, commit 0b04fe6d8302179659970850d4e46e39118144ae does a AC_CHECK_FUNCS() to determine the location of shm_open(), allowing us to avoid -lrt.
(In reply to Christian Hergert from comment #5) > I simplified things to use atomics if we don't have rdtscp (since ensuring > that sched_getcpu() is fast is difficult across all platforms anyway). > > Additionally, commit 0b04fe6d8302179659970850d4e46e39118144ae does a > AC_CHECK_FUNCS() to determine the location of shm_open(), allowing us to > avoid -lrt. That's just perfect. Thanks Christian :-)