After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747305 - x11/gl: Use after free in glx_pixmap_get()
x11/gl: Use after free in glx_pixmap_get()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-04-03 15:56 UTC by Olivier Fourdan
Modified: 2015-04-05 11:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.65 KB, patch)
2015-04-03 15:57 UTC, Olivier Fourdan 		none Details | Review
Proposed patch (1.62 KB, patch)
2015-04-03 15:58 UTC, Olivier Fourdan 		committed Details | Review

Description Olivier Fourdan 2015-04-03 15:56:09 UTC 
https://git.gnome.org/browse/gtk+/tree/gdk/x11/gdkglcontext-x11.c#n399


  XFree (fbconfigs);
  ...
  glx_pixmap->drawable = glXCreatePixmap (display, fbconfigs[i], <=== here
					  cairo_xlib_surface_get_drawable (surface),
					  pixmap_attributes);

  return glx_pixmap;
Comment 1 Olivier Fourdan 2015-04-03 15:57:13 UTC 
Created attachment 300898 [details] [review]
Proposed patch
Comment 2 Olivier Fourdan 2015-04-03 15:58:53 UTC 
Created attachment 300899 [details] [review]
Proposed patch
Comment 3 Emmanuele Bassi (:ebassi) 2015-04-03 19:07:32 UTC 
Review of attachment 300899 [details] [review]:

Nice catch.

Please, push to master and cherry-pick to the gtk-3-16 branch as well.