Created attachment 300862 [details] [review]
daemon: Check that we're using the X backend before using it

This won't make us work correctly on other backends but at least we
won't print criticals anymore.

Created attachment 300863 [details] [review]
display-adapter: Allow setting an external default adapter instance

This will allow gnome-shell, when running as a native wayland
compositor, to set its own display adapter implementation since the X
one doesn't work for that case.

Review of attachment 300862 [details] [review]:

OK.

Review of attachment 300863 [details] [review]:

::: libcaribou/display-adapter.vala
@@ +112,2 @@
         static DisplayAdapter instance;
+        public static bool set_default (DisplayAdapter adapter) {

Perhaps this function could take the class of the adapter instead of an object, so we don't need to worry about whether the instance is already set.

Anyway either is fine, as it's a short term solution.  I guess it would be nicer that we could abandon the display related stuff in caribou and do that in gnome-shell instead.

(In reply to Daiki Ueno from comment #4)
> ::: libcaribou/display-adapter.vala
> @@ +112,2 @@
>          static DisplayAdapter instance;
> +        public static bool set_default (DisplayAdapter adapter) {
>

> Perhaps this function could take the class of the adapter instead of
> an object, so we don't need to worry about whether the instance is
> already set.

This wouldn't allow me to implement the DisplayAdapter in JavaScript
though :-)

> Anyway either is fine, as it's a short term solution.  I guess it
> would be nicer that we could abandon the display related stuff in
> caribou and do that in gnome-shell instead.

Yes, definitely. Thanks

Attachment 300862 [details] pushed as e3c2625 - daemon: Check that we're using the X backend before using it
Attachment 300863 [details] pushed as ad154e7 - display-adapter: Allow setting an external default adapter instance