After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747217 - dtlssrtpenc/dec: Should reset its state when going back to NULL
dtlssrtpenc/dec: Should reset its state when going back to NULL
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-02 03:06 UTC by Olivier Crête
Modified: 2018-11-03 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dtlssrtp: recreate dtls element when going from NULL to READY (6.93 KB, patch)
2015-09-10 06:56 UTC, Hyunjun Ko 		reviewed Details | Review

Description Olivier Crête 2015-04-02 03:06:25 UTC 
Currently, setting the srtp-*/srtcp-* properties destroys the dtls element, but there is not way to restore it when changing states.

It should probably re-create the sub-elements when going from NULL->READY if none of those propertties are set. Probalby also makes sense to re-create it if they are all resets to NULL.
Comment 1 Hyunjun Ko 2015-09-09 09:38:08 UTC 
IMHO, creating vmethod create_dtls_element in dtlssrtpbin and calling it in change_state method is a possible way as you said.
Comment 2 Hyunjun Ko 2015-09-10 06:56:27 UTC 
Created attachment 311036 [details] [review]
dtlssrtp: recreate dtls element when going from NULL to READY
Comment 3 Olivier Crête 2018-05-05 11:31:58 UTC 
Review of attachment 311036 [details] [review]:

::: ext/dtls/gstdtlssrtpdec.c
@@ +442,3 @@
+  }
+
+  bin->dtls_element = gst_element_factory_make ("dtlsdec", "dtls-decoder");

Can you leave the name as NULL because having specific names makes it harder to grep through debug logs.

@@ +456,3 @@
+
+  g_signal_connect (bin->dtls_element, "notify::peer-pem",
+      G_CALLBACK (on_peer_pem), self);

Don't you want to connect the signal before you link the pads ?
Comment 4 GStreamer system administrator 2018-11-03 13:32:53 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/227.