After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747205 - Meta+N does not focus text field in a chat in notification tray
Meta+N does not focus text field in a chat in notification tray
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 747978 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-04-01 20:54 UTC by christianbboman
Modified: 2015-04-16 16:32 UTC
See Also:
GNOME target: ---
GNOME version: 3.15/3.16


Attachments
messageTray: Make notification banners unfocusable (998 bytes, patch)
2015-04-16 14:19 UTC, Florian Müllner
committed Details | Review

Description christianbboman 2015-04-01 20:54:30 UTC
In 3.14, Meta+N focused the current notification. In the case of a message from Empathy, you could press Meta+N, reply to your message, and hit enter to send the reply. 

Since upgrading to 3.16, this functionality is broken. Meta+N focuses the current notification, but the actual text field to reply in does not get focus. This means you have to click on the text field to reply making the Meta+N shortcut useless (for chat messages). 

This is on Arch Linux x64, gnome-shell 3.16.0-1, empathy 3.12.8-1.
Comment 1 Florian Müllner 2015-04-16 10:17:37 UTC
*** Bug 747978 has been marked as a duplicate of this bug. ***
Comment 2 Florian Müllner 2015-04-16 14:19:17 UTC
Created attachment 301735 [details] [review]
messageTray: Make notification banners unfocusable

Unlike entries in the calendar's message list, banners are not subject
to the normal keynav chain, and making the banner actor itself unfocusable
allows for the focus to be moved to the action area when expanded.


This patch should restore the pre-3.16 behavior, though it has implications on accessibility, so we're still figuring out the best approach forward.
Comment 3 maxime.deroucy 2015-04-16 16:07:19 UTC
I confirm that the patch (attachment 301735 [details] [review]) works.

Thanks a lot.

Just a little remark : once in the text field it is not possible to leave it by hitting the "escape" key. I have to hit Alt+Tab ; not very intuitive but I will not complain :)

Regards
Comment 4 Joanmarie Diggs (IRC: joanie) 2015-04-16 16:25:11 UTC
And to confirm what was discussed in #gnome-shell, the patch doesn't have negative implications for accessibility, and in fact makes things more accessible. Orca presents notifications based on role; not the focused object. Orca works fine with this patch, and Orca users need for the text field to have focus so they can type there -- just like any other user. :)
Comment 5 Florian Müllner 2015-04-16 16:32:18 UTC
Attachment 301735 [details] pushed as 9917f05 - messageTray: Make notification banners unfocusable

OK, let's go with it then ...

(I'll also push the patch to gnome-3-16, so that it gets included in 3.16.2 ...)