After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747185 - Void function should not return a value in src/gs-category.c
Void function should not return a value in src/gs-category.c
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-01 14:40 UTC by Ting-Wei Lan
Modified: 2015-04-01 23:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
trivial: Fix "void function should not return a value" (758 bytes, patch)
2015-04-01 14:41 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2015-04-01 14:40:56 UTC
gs_category_set_size doesn't have a return value, so we should use g_return_if_fail instead of g_return_val_if_fail.
Comment 1 Ting-Wei Lan 2015-04-01 14:41:44 UTC
Created attachment 300754 [details] [review]
trivial: Fix "void function should not return a value"
Comment 2 Michael Catanzaro 2015-04-01 23:47:23 UTC
Thank you!

Attachment 300754 [details] pushed as 19a92d5 - trivial: Fix "void function should not return a value"