GNOME Bugzilla – Bug 747126
androidmedia: add support for more color formats
Last modified: 2015-05-04 10:46:06 UTC
The following patchset add support for various color formats.
Created attachment 300684 [details] [review] androidmedia: Add suport for Intel color formats
Created attachment 300685 [details] [review] androidmedia: Add support for COLOR_FormatYUV420Flexible
Created attachment 300686 [details] [review] androidmedia: Add basic support for QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView
Created attachment 302636 [details] [review] androidmedia: Declare QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView constant Patch updated: only declare the relevant constant and do not try to implement partial support without any testing due to the lack of relevant samples (H264/MVC) and supports in h264parse.
Created attachment 302807 [details] [review] androidmedia: Add support for COLOR_FormatYV12 The following patch is untested due to lack of proper device. It happens to be found on tegra2 devices.
Comment on attachment 302636 [details] [review] androidmedia: Declare QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView constant What's the point of adding this constant but not using it?
Comment on attachment 302807 [details] [review] androidmedia: Add support for COLOR_FormatYV12 YV12 is in YVU order, not YUV. So not exactly the same as I420 and the others. You might need to swap the planes.
(In reply to Sebastian Dröge (slomo) from comment #6) > Comment on attachment 302636 [details] [review] [review] > androidmedia: Declare QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView > constant > > What's the point of adding this constant but not using it? So we know what its value stands for as it is not part of the documentation and I had trouble finding what it was meaning. It is reported by my nexus5 device (android 5.1). (In reply to Sebastian Dröge (slomo) from comment #7) > Comment on attachment 302807 [details] [review] [review] > androidmedia: Add support for COLOR_FormatYV12 > > YV12 is in YVU order, not YUV. So not exactly the same as I420 and the > others. You might need to swap the planes. It is covered under the same case as COLOR_FormatYUV420Planar and COLOR_FormatYUV420Flexible to compute the frame_size and it is mapped to GST_VIDEO_FORMAT_YV12 in color_format_mapping_table[]. Isn't it enough ? I'm not a huge fan at sending this kind of patch without testing but I don't have the relevant device.
Comment on attachment 302807 [details] [review] androidmedia: Add support for COLOR_FormatYV12 Makes sense and should be correct indeed. In the worst case the colors are wrong now and we get a report about that, still more useful then getting a report about codecs not working at all :)