After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747093 - When system theme is dark version of Adwaita, close button looks ugly
When system theme is dark version of Adwaita, close button looks ugly
Status: RESOLVED FIXED
Product: notification-daemon
Classification: Other
Component: general
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: notification-daemon-maint
notification-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-31 07:20 UTC by Dmitry Shachnev
Modified: 2015-04-16 23:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A screenshot (10.72 KB, image/png)
2015-03-31 07:20 UTC, Dmitry Shachnev 		  Details
nd-bubble: stop using style-set signal (8.22 KB, patch)
2015-04-14 20:48 UTC, Alberts Muktupāvels 		committed Details | Review

Description Dmitry Shachnev 2015-03-31 07:20:01 UTC 
Created attachment 300645 [details]
A screenshot

Please see the attached screenshot.

When light version of Adwaita is used, both the notification itself and the button are dark, but then the button is hardly visible.

Perhaps the button itself should follow the notification coloring, but the X symbol should be made more contrast.
Comment 1 Alberts Muktupāvels 2015-04-14 20:48:30 UTC 
Created attachment 301573 [details] [review]
nd-bubble: stop using style-set signal

On style set override_style function is called. It is using
deprecated GtkStyle and related functions. With this function
removed notification bubble looks 100% better.
Comment 2 Alberts Muktupāvels 2015-04-14 20:52:16 UTC 
What do you think about my patch?

Do you know where I could find screenshots where I could see how this bubble used to look like in past. I don't think that it looked like this (without patch) all time.
Comment 3 Dmitry Shachnev 2015-04-16 18:15:09 UTC 
Your patch definitely improves the look, thanks.

I don't know a specific screenshots source, but searching for "notification-daemon" in google images does find something (most of the results are not *our* notification-daemon, but some are).