After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747065 - build error with -Werror=format-security
build error with -Werror=format-security
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: file-roller-maint
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-30 23:00 UTC by darkxst
Modified: 2015-03-31 08:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk-utils: fix missing string format argument (866 bytes, patch)
2015-03-30 23:01 UTC, darkxst 		none Details | Review
gtk-utils: fix missing string format argument (1.23 KB, patch)
2015-03-30 23:12 UTC, darkxst 		none Details | Review

Description darkxst 2015-03-30 23:00:52 UTC 
Build fails when built with -Werror=format-security

gtk-utils.c: In function '_gtk_message_dialog_new':
gtk-utils.c:73:2: error: format not a string literal and no format arguments [-Werror=format-security]
  gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog), secondary_message);
  ^
gtk-utils.c: In function '_gtk_error_dialog_new':
gtk-utils.c:214:3: error: format not a string literal and no format arguments [-Werror=format-security]
   gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog), secondary_message);
   ^
cc1: some warnings being treated as errors
Comment 1 darkxst 2015-03-30 23:01:30 UTC 
Created attachment 300634 [details] [review]
gtk-utils: fix missing string format argument
Comment 2 darkxst 2015-03-30 23:12:07 UTC 
Created attachment 300635 [details] [review]
gtk-utils: fix missing string format argument
Comment 3 Paolo Bacchilega 2015-03-31 08:05:31 UTC 
patch applied to master, thank you.