After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747037 - provide a scalable -symbolic variant of the app icon
provide a scalable -symbolic variant of the app icon
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-30 15:45 UTC by Jakub Steiner
Modified: 2015-04-13 21:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
icon: provide a symbolic variant of the app icon (18.25 KB, patch)
2015-03-30 15:45 UTC, Jakub Steiner 		none Details | Review
icon: provide a symbolic variant of the app icon (18.46 KB, patch)
2015-04-13 15:28 UTC, Jakub Steiner 		none Details | Review

Description Jakub Steiner 2015-03-30 15:45:09 UTC 
Starting with GNOME 3.16 we streamlined how high contrast icons are managed. The attached patch includes a symbolic variant of the app icon that is used for HC theme and recolorable at runtime.

See https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons for more details.
Comment 1 Jakub Steiner 2015-03-30 15:45:31 UTC 
Created attachment 300604 [details] [review]
icon: provide a symbolic variant of the app icon

since gnome 3.16 we're using recolorable symbolic icons
for the high contrast accessible theme
Comment 2 Paolo Borelli 2015-03-30 17:43:23 UTC 
Review of attachment 300604 [details] [review]:

Thanks Jakub.

Just a couple of minor things to fix up. Feel free to amend and push directly.

::: Makefile.am
@@ -63,3 @@
-hcicon48_DATA = data/icons/HighContrast/48x48/apps/gnome-clocks.png
-hcicon256dir = $(datadir)/icons/HighContrast/256x256/apps
-hcicon24_DATA = data/icons/HighContrast/24x24/apps/gnome-clocks.png

Please git rm these files

@@ -64,3 @@
-hcicon256dir = $(datadir)/icons/HighContrast/256x256/apps
-hcicon256_DATA = data/icons/HighContrast/256x256/apps/gnome-clocks.png
-hcicon24_DATA = data/icons/HighContrast/24x24/apps/gnome-clocks.png

I guess you also need to remove hcicon_files from EXTRA_DIST
Comment 3 Jakub Steiner 2015-04-13 15:28:16 UTC 
Created attachment 301466 [details] [review]
icon: provide a symbolic variant of the app icon

since gnome 3.16 we're using recolorable symbolic icons
for the high contrast accessible theme
Comment 4 Paolo Borelli 2015-04-13 21:51:54 UTC 
this was pushed