After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747032 - Fix possible crash in ostree_mutable_tree_walk()
Fix possible crash in ostree_mutable_tree_walk()
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-30 14:57 UTC by Sam Thursfield
Modified: 2015-03-31 17:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix possible crash in ostree_mutable_tree_walk() (1.92 KB, patch)
2015-03-30 14:59 UTC, Sam Thursfield 		accepted-commit_now Details | Review

Description Sam Thursfield 2015-03-30 14:57:50 UTC 
Test suite in 'master' is failing:

./test-mutable-tree 
/mutable-tree/metadata-checksum: OK
/mutable-tree/contents-checksum: OK
/mutable-tree/parent-dirs: OK
/mutable-tree/walk: Segmentation fault (core dumped)
Comment 1 Sam Thursfield 2015-03-30 14:59:08 UTC 
Created attachment 300601 [details] [review]
Fix possible crash in ostree_mutable_tree_walk()
Comment 2 Matthew Barnes 2015-03-31 14:32:43 UTC 
Review of attachment 300601 [details] [review]:

The code was certainly mishandling that condition.  Given that the caller provides the array and a bounds check is trivial, I agree with calling an illegal initial condition a programming error.