After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747011 - provide a scalable -symbolic variant of the app icon
provide a scalable -symbolic variant of the app icon
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: core application
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-30 11:04 UTC by Jakub Steiner
Modified: 2015-08-31 21:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icon: provide a symbolic variant of the app icon (25.48 KB, patch)
2015-03-30 11:04 UTC, Jakub Steiner
none Details | Review
icon: provide a symbolic variant of the app icon (26.48 KB, patch)
2015-04-02 15:33 UTC, Jakub Steiner
committed Details | Review

Description Jakub Steiner 2015-03-30 11:04:34 UTC
Starting with GNOME 3.16 we streamlined how high contrast icons are managed. The attached patch includes a symbolic variant of the app icon that is used for HC theme and recolorable at runtime.

See https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons for more details.

In case of Anjuta the symbolic variant was available, but not installed.
Comment 1 Jakub Steiner 2015-03-30 11:04:55 UTC
Created attachment 300573 [details] [review]
icon: provide a symbolic variant of the app icon

- since 3.16 a symbolic variant is used for High Contrast accessible
  theme.
Comment 2 Jakub Steiner 2015-04-02 15:33:34 UTC
Created attachment 300832 [details] [review]
icon: provide a symbolic variant of the app icon

- since 3.16 a symbolic variant is used for High Contrast accessible
  theme.

The symbolic size has been introduced to hicolor to cope with
the nominal size of 16x16 rather than the backward compatible
128x128.
Comment 3 Michael Catanzaro 2015-05-13 13:06:02 UTC
Review of attachment 300832 [details] [review]:

There's no icon in this patch
Comment 4 Jakub Steiner 2015-08-31 08:20:19 UTC
The summary hints it has moved the SVG. As mentioned it was available but not installed.

 configure.ac                                       |   7 -------
 pixmaps/HighContrast/16x16/Makefile.am             |   4 ----
 pixmaps/HighContrast/16x16/anjuta.png              | Bin 468 -> 0 bytes
 pixmaps/HighContrast/22x22/Makefile.am             |   4 ----
 pixmaps/HighContrast/22x22/anjuta.png              | Bin 631 -> 0 bytes
 pixmaps/HighContrast/24x24/Makefile.am             |   4 ----
 pixmaps/HighContrast/24x24/anjuta.png              | Bin 663 -> 0 bytes
 pixmaps/HighContrast/256x256/Makefile.am           |   4 ----
 pixmaps/HighContrast/256x256/anjuta.png            | Bin 10209 -> 0 bytes
 pixmaps/HighContrast/32x32/Makefile.am             |   4 ----
 pixmaps/HighContrast/32x32/anjuta.png              | Bin 968 -> 0 bytes
 pixmaps/HighContrast/48x48/Makefile.am             |   4 ----
 pixmaps/HighContrast/48x48/anjuta.png              | Bin 1472 -> 0 bytes
 pixmaps/HighContrast/Makefile.am                   |   1 -
 pixmaps/Makefile.am                                |   4 ++--
 pixmaps/hicolor/Makefile.am                        |   2 +-
 pixmaps/hicolor/scalable/Makefile.am               |   2 +-
 pixmaps/hicolor/symbolic/Makefile.am               |   7 +++++++
 pixmaps/{ => hicolor/symbolic}/anjuta-symbolic.svg |   0
 19 files changed, 11 insertions(+), 36 deletions(-)
 delete mode 100644 pixmaps/HighContrast/16x16/Makefile.am
 delete mode 100644 pixmaps/HighContrast/16x16/anjuta.png
 delete mode 100644 pixmaps/HighContrast/22x22/Makefile.am
 delete mode 100644 pixmaps/HighContrast/22x22/anjuta.png
 delete mode 100644 pixmaps/HighContrast/24x24/Makefile.am
 delete mode 100644 pixmaps/HighContrast/24x24/anjuta.png
 delete mode 100644 pixmaps/HighContrast/256x256/Makefile.am
 delete mode 100644 pixmaps/HighContrast/256x256/anjuta.png
 delete mode 100644 pixmaps/HighContrast/32x32/Makefile.am
 delete mode 100644 pixmaps/HighContrast/32x32/anjuta.png
 delete mode 100644 pixmaps/HighContrast/48x48/Makefile.am
 delete mode 100644 pixmaps/HighContrast/48x48/anjuta.png
 delete mode 100644 pixmaps/HighContrast/Makefile.am
 create mode 100644 pixmaps/hicolor/symbolic/Makefile.am
 rename pixmaps/{ => hicolor/symbolic}/anjuta-symbolic.svg (100%)
Comment 5 Michael Catanzaro 2015-08-31 17:32:37 UTC
My "problem" was that Splinter doesn't show moved files :)
Comment 6 Michael Catanzaro 2015-08-31 17:33:39 UTC
Attachment 300832 [details] pushed as 2439e2b - icon: provide a symbolic variant of the app icon
Comment 7 Vadim Rutkovsky 2015-08-31 18:24:15 UTC
(In reply to Michael Catanzaro from comment #6)
> Attachment 300832 [details] pushed as 2439e2b - icon: provide a symbolic
> variant of the app icon

This commit breaks Continuous build: http://build.gnome.org/continuous/buildmaster/builds/2015/08/31/55/build/log-anjuta.txt
Comment 8 Vadim Rutkovsky 2015-08-31 18:26:52 UTC
Please revert https://git.gnome.org/browse/gnome-continuous/commit/?id=369293fa1d2ce6410dc8d61f028c2f96ca892d46 after commit with the fix is pushed
Comment 9 Michael Catanzaro 2015-08-31 21:09:45 UTC
My bad