GNOME Bugzilla – Bug 746957
validate:launcher: Show timeout seconds for timeout result message
Last modified: 2015-06-24 14:44:23 UTC
Current timeout message doesn't show how many seconds a test took and it is timeouted by normal timeout or hard timeout like following. 1. normal timeout validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out) 2. hard timeout validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out) Note that Test::process_update sets specific error message for hard_timeout case, but it is over written by Test::check_results.
Created attachment 300530 [details] [review] Show timeout seconds for timeout result message This patch changes the message like following. 1. normal timeout old : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out) new : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out: 120 secs) 2. hard timeout old : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out) new : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Hard timeout reached: 600 secs)
Thibault, would you review this as well?
Review of attachment 300530 [details] [review]: I can not find where it set "(Hard timeout reached" ? Otherwize looks good.
The existing code already has it. Please refer to the following link. http://phabricator.freedesktop.org/diffusion/GSTDEV/browse/master/validate/launcher/baseclasses.py;4c7ec6b8b13a7c1ec1f8c4e8a9ddab887c1e54aa$242 But, for now, the message is being overwritten by Test::check_results.
commit 4725f4ec099cace11b680ca7ca916362a4ad14c0 Author: Young Han Lee <y.lee@lge.com> Date: Sun Mar 29 11:13:01 2015 +0900 validate:launcher: Show timeout seconds for timeout result message Current timeout message doesn't show how many seconds a test took and it is timeouted by normal timeout or hard timeout. This patch changes the message like following. 1. normal timeout old : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out) new : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out: 120 secs) 2. hard timeout old : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out) new : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Hard timeout reached: 600 secs) https://bugzilla.gnome.org/show_bug.cgi?id=746957 (In reply to Young Han Lee from comment #4) > The existing code already has it. Please refer to the following link. > > http://phabricator.freedesktop.org/diffusion/GSTDEV/browse/master/validate/ > launcher/baseclasses.py;4c7ec6b8b13a7c1ec1f8c4e8a9ddab887c1e54aa$242 > > But, for now, the message is being overwritten by Test::check_results. Got it, thanks.
Thanks for your review!