After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746902 - st-theme-node: Unconditionally apply style margins on the actor
st-theme-node: Unconditionally apply style margins on the actor
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-27 16:45 UTC by Rui Matos
Modified: 2015-03-27 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st-theme-node: Unconditionally apply style margins on the actor (3.18 KB, patch)
2015-03-27 16:45 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2015-03-27 16:45:08 UTC 
We currently don't have any code either in gnome-shell or
gnome-shell-extensions setting margins directly with the Clutter API.

On the other hand, the current behavior doesn't allow us to remove a
style class with margins and have that be reflected, so removing this
special casing seems like the right thing to do at this point.
Comment 1 Rui Matos 2015-03-27 16:45:12 UTC 
Created attachment 300477 [details] [review]
st-theme-node: Unconditionally apply style margins on the actor
Comment 2 Florian Müllner 2015-03-27 17:00:58 UTC 
Review of attachment 300477 [details] [review]:

::: src/st/st-theme-node.c
@@ +1674,2 @@
   if (left)
     {

Braces no longer necessary (not that they hurt of course ...)
Comment 3 Rui Matos 2015-03-27 17:07:40 UTC 
Removed the braces before pushing, thanks

Attachment 300477 [details] pushed as 216e996 - st-theme-node: Unconditionally apply style margins on the actor