After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746765 - mpegtsmux: Remove arbitrary constraint on prog-map program ids
mpegtsmux: Remove arbitrary constraint on prog-map program ids
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-25 17:49 UTC by Yanko Kaneti
Modified: 2015-06-11 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove arbitrary constraint on prog-map program ids (3.18 KB, patch)
2015-03-25 17:49 UTC, Yanko Kaneti 		none Details | Review
patch - v2 (3.54 KB, patch)
2015-06-10 08:39 UTC, Yanko Kaneti 		none Details | Review

Description Yanko Kaneti 2015-03-25 17:49:44 UTC 
Created attachment 300301 [details] [review]
Remove arbitrary constraint on prog-map program ids

Currently there is an arbitrary limit of 32 for program ids in prog-map, which seems to be tied only to the chosen implementation. 
Use a hash table to remove it.
Comment 1 Yanko Kaneti 2015-04-06 17:22:06 UTC 
ping?
Comment 2 Jesper Larsen 2015-06-10 08:10:27 UTC 
Looks good. Although, your patch is leaking memory.

You need to clean up the hash table. (see g_hash_table_destroy)
Comment 3 Yanko Kaneti 2015-06-10 08:39:45 UTC 
Created attachment 304926 [details] [review]
patch - v2

Thanks for looking into it.
I've added a g_hash_table_destroy on reset and destroy
Comment 4 Jan Schmidt 2015-06-11 14:20:44 UTC 
Thanks for the patch! Pushed: 

commit fa9fa5d460d2553c8cac431e71471c12f30d7139
Author: Yanko Kaneti <yaneti@declera.com>
Date:   Wed Mar 25 19:27:42 2015 +0200

    mpegtsmux: Remove arbitrary constraint on prog-map program ids
    
    https://bugzilla.gnome.org/show_bug.cgi?id=746765