After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746740 - Makefile.instrospection: search for MINGW instead of MINGW32
Makefile.instrospection: search for MINGW instead of MINGW32
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-25 13:36 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2015-03-25 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Makefile.instrospection: search for MINGW instead of MINGW32 (1.32 KB, patch)
2015-03-25 13:36 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
Makefile.instrospection: search for MINGW instead of MINGW32 (1.36 KB, patch)
2015-03-25 13:37 UTC, Ignacio Casal Quinteiro (nacho) 		accepted-commit_now Details | Review

Description Ignacio Casal Quinteiro (nacho) 2015-03-25 13:36:35 UTC 
On mingw64 the right string to search is MINGW64 so instead of
search for a specific one we just search for the generic MINGW
Comment 1 Ignacio Casal Quinteiro (nacho) 2015-03-25 13:36:41 UTC 
Created attachment 300274 [details] [review]
Makefile.instrospection: search for MINGW instead of MINGW32
Comment 2 Ignacio Casal Quinteiro (nacho) 2015-03-25 13:37:50 UTC 
Created attachment 300275 [details] [review]
Makefile.instrospection: search for MINGW instead of MINGW32

On mingw64 the right string to search is MINGW64 so instead of
search for a specific one we just search for the generic MINGW.
Thanks Alexey for finding out this problem.
Comment 3 Dieter Verfaillie 2015-03-25 14:20:28 UTC 
Review of attachment 300275 [details] [review]:

Looks good to me
Comment 4 Ignacio Casal Quinteiro (nacho) 2015-03-25 14:30:40 UTC 
Attachment 300275 [details] pushed as 2699b11 - Makefile.instrospection: search for MINGW instead of MINGW32