After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746612 - Geoclue2 requires a DesktopId property
Geoclue2 requires a DesktopId property
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Geolocation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-22 17:36 UTC by Fabrice Bellet
Modified: 2015-03-23 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
geoclue-helper: provides a required DesktopId (956 bytes, patch)
2015-03-22 17:36 UTC, Fabrice Bellet 		none Details | Review
geoclue-helper: Provide a DesktopId (1.35 KB, patch)
2015-03-23 14:19 UTC, Debarshi Ray 		committed Details | Review

Description Fabrice Bellet 2015-03-22 17:36:34 UTC 
Created attachment 300083 [details] [review]
geoclue-helper: provides a required DesktopId

Recent versions of Geoclue2 made mandatory for the client to provide a DesktopId. This patch provides the desktop-id "empathy".
Comment 1 Zeeshan Ali 2015-03-23 13:46:52 UTC 
Review of attachment 300083 [details] [review]:

Looks good to me. I can't tell from the patch but please ensure that you do this before you start the client.
Comment 2 Debarshi Ray 2015-03-23 14:05:53 UTC 
Review of attachment 300083 [details] [review]:

The DesktopId property was added in geoclue-2.1.0, whereas empathy currently requires 1.99.3. We need to bump the requirement so that a newer version of the XML is used to generate the DBus bindings.
Comment 3 Debarshi Ray 2015-03-23 14:19:59 UTC 
Created attachment 300138 [details] [review]
geoclue-helper: Provide a DesktopId
Comment 4 Debarshi Ray 2015-03-23 14:20:48 UTC 
From #empathy on GIMPNet:

14:13 <rishi> cassidy: xclaesse:                                                
      https://bugzilla.gnome.org/show_bug.cgi?id=746612
14:13 <rishi> Can we push it after bumping the geoclue requirement?
14:14 <rishi> geoclue-2.1.0 should be ok for 3.12.x. It was released in Jan     
      2014.
14:15 <cassidy> rishi, yeah go for it