After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746498 - no smooth transition between plymouth and wayland login screen
no smooth transition between plymouth and wayland login screen
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-20 02:42 UTC by Ray Strode [halfline]
Modified: 2015-03-24 14:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
manager: don't block on plymouth quitting (2.98 KB, patch)
2015-03-20 02:42 UTC, Ray Strode [halfline]
committed Details | Review
manager: add hack to quit plymouth after a delay (2.40 KB, patch)
2015-03-20 02:42 UTC, Ray Strode [halfline]
committed Details | Review
Revert "manager: add hack to quit plymouth after a delay" (2.26 KB, patch)
2015-03-23 13:27 UTC, Ray Strode [halfline]
accepted-commit_after_freeze Details | Review
manager: add a different hack to quit plymouth later (10.11 KB, patch)
2015-03-23 13:27 UTC, Ray Strode [halfline]
accepted-commit_after_freeze Details | Review

Description Ray Strode [halfline] 2015-03-20 02:42:32 UTC
Right now we briefly see the console between plymouth and the login screen.
Comment 1 Ray Strode [halfline] 2015-03-20 02:42:36 UTC
Created attachment 299903 [details] [review]
manager: don't block on plymouth quitting

plymouth can quit in the background, the only thing we need to block
synchronously on is it deactivating.
Comment 2 Ray Strode [halfline] 2015-03-20 02:42:40 UTC
Created attachment 299904 [details] [review]
manager: add hack to quit plymouth after a delay

Right now wayland sessions register with GDM before they're
actually ready, so we quit plymouth too soon.

Until we can fix that, this commit adds a sleep 5 hack to
quit plymouth a little after registration.
Comment 3 Ray Strode [halfline] 2015-03-20 02:42:57 UTC
Attachment 299903 [details] pushed as f349c6c - manager: don't block on plymouth quitting
Attachment 299904 [details] pushed as 862ba1b - manager: add hack to quit plymouth after a delay
Comment 4 Ray Strode [halfline] 2015-03-23 12:46:25 UTC
Noticed this in the continuous log:

gdm: sleep: invalid option -- '-'

I guess the hack actually prevents plymouth from quitting at all at the designated time and then it just happens to quit later using the withouth_transition codepath (and we're already in graphics mode so it stays flicker free)
Comment 5 Ray Strode [halfline] 2015-03-23 13:27:18 UTC
Created attachment 300130 [details] [review]
Revert "manager: add hack to quit plymouth after a delay"

This reverts commit 862ba1bd67ec85b5784d3e8809a405f1845b1c43.
Comment 6 Ray Strode [halfline] 2015-03-23 13:27:30 UTC
Created attachment 300131 [details] [review]
manager: add a different hack to quit plymouth later

Right now wayland sessions register with GDM before they're
actually ready, so we quit plymouth too soon.

Until we can fix that, this commit quits plymouth when the login screen
connects to the daemon, or in the event of automatic login (where there
is no login screen), after 20 seconds.

This is like commit 862ba1bd67ec85b5784d3e8809a405f1845b1c43
but hopefully less broken..
Comment 7 Ray Strode [halfline] 2015-03-24 14:45:29 UTC
Attachment 300130 [details] pushed as c46f1f6 - Revert "manager: add hack to quit plymouth after a delay"
Attachment 300131 [details] pushed as 2cbd7ad - manager: add a different hack to quit plymouth later