After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746386 - clipboard crash when other client becomes the selection owner
clipboard crash when other client becomes the selection owner
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-03-18 10:19 UTC by Carlos Garnacho
Modified: 2015-03-18 11:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Fix thinko in wl_data_source.cancelled handler (1.74 KB, patch)
2015-03-18 10:21 UTC, Carlos Garnacho 		none Details | Review

Description Carlos Garnacho 2015-03-18 10:19:40 UTC 
On wl_data_source.cancel, we (needlessly) assume the data source has a DnD context related, which is not true for the selection. This causes crashes as seen in https://retrace.fedoraproject.org/faf/problems/672153/.
Comment 1 Carlos Garnacho 2015-03-18 10:21:40 UTC 
The fix is now in master, this should be considered as well for 3.16.

The following fix has been pushed:
dcfa55a wayland: Fix thinko in wl_data_source.cancelled handler
Comment 2 Carlos Garnacho 2015-03-18 10:21:45 UTC 
Created attachment 299690 [details] [review]
wayland: Fix thinko in wl_data_source.cancelled handler

The wl_data_source may be the clipboard's. Looking up the drag context in
order to get the display isn't going to fare well there. So, just use the
default display, and only look up the drag context when we know we need it.
Comment 3 Carlos Garnacho 2015-03-18 11:17:08 UTC 
The fix is now in gtk-3-16 as well.

Attachment 299690 [details] pushed as 17b65d3 - wayland: Fix thinko in wl_data_source.cancelled handler