Created attachment 299590 [details] [review]
telepathyClient: Don't remove body on updates

Passing null as body always meant clearing the existing one. While this
mattered less with the old message tray which used the expanded actor,
the new message list in the calendar uses the unexpanded body. We clearly
don't want that to disappear on icon changes, so pass the existing one.

Created attachment 299591 [details] [review]
Revert "messageTray: Special-case chat notifications to use the old actor"

This was really just a temporary hack to buy us more time to properly port
chat notifications to the new banners ...

This reverts commit cd5318baa7699923f9757e25576c9fb4e3aef2ac.

Created attachment 299592 [details] [review]
messageTray: Always destroy banners when done displaying

Special-casing banners of resident notifications was really a
thinly veiled special case for chat notifications, as those were
still using the old notification actor which coupled the life-time
of the notification to its actor. This is no longer the case, so
we can do the sane thing and destroy banners once they are no
longer needed.

Created attachment 299593 [details] [review]
telepathyClient: Provide a custom banner implementation

Since we stopped special-casing chat notifications to use the old
notification actor, we need to provide a notification banner to
maintain the inline chat functionality, so split out the UI from
the existing ChatNotification class.

Created attachment 299594 [details] [review]
messageTray: Stop including an actor with Notifications

We now stopped using notification actors directly for anything, so
we can simplify the Notification class significantly by turning it
into a purely informational object others can use to built their UI
representation from.

Review of attachment 299590 [details] [review]:

Ok, although seems more clear if no passing anything means "use whatever you had before". So we will need all in params.
But the change doesn't worth the effort I guess =)

Review of attachment 299591 [details] [review]:

-y

Review of attachment 299592 [details] [review]:

yay

Review of attachment 299593 [details] [review]:

awesome!!! finally that gap in the left fixed...

code looks ok

Review of attachment 299593 [details] [review]:

awesome!!! finally that gap in the left fixed...

code looks ok

Review of attachment 299594 [details] [review]:

yes

Attachment 299590 [details] pushed as 0ee7622 - telepathyClient: Don't remove body on updates
Attachment 299591 [details] pushed as 54f46e8 - Revert "messageTray: Special-case chat notifications to use the old actor"
Attachment 299592 [details] pushed as 2d4ba30 - messageTray: Always destroy banners when done displaying
Attachment 299593 [details] pushed as bb61dd4 - telepathyClient: Provide a custom banner implementation
Attachment 299594 [details] pushed as 15e42c4 - messageTray: Stop including an actor with Notifications