After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746242 - matroskaparse: send global tags
matroskaparse: send global tags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-15 11:51 UTC by Ramiro Polla
Modified: 2015-03-28 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
matroskaparse: send global tags (2.77 KB, patch)
2015-03-15 11:51 UTC, Ramiro Polla 		none Details | Review
matroskaparse: send global tags (2.91 KB, patch)
2015-03-15 12:52 UTC, Ramiro Polla 		none Details | Review
matroskaparse: send global tags (4.21 KB, patch)
2015-03-15 15:10 UTC, Ramiro Polla 		committed Details | Review

Description Ramiro Polla 2015-03-15 11:51:56 UTC 
Currently matroskaparse ignores global tags.
Comment 1 Ramiro Polla 2015-03-15 11:51:59 UTC 
Created attachment 299448 [details] [review]
matroskaparse: send global tags
Comment 2 Sebastian Dröge (slomo) 2015-03-15 12:36:57 UTC 
Why are you sending the global tags in multiple places? You need to merge all global tags and then send the merged tags downstream, instead of sending partial tags a few times.
Comment 3 Ramiro Polla 2015-03-15 12:52:17 UTC 
Created attachment 299450 [details] [review]
matroskaparse: send global tags

Global tags are already being read in matroskaparse, but they are not
currently being sent. This patch makes tags get sent whenever they are
found.
Comment 4 Ramiro Polla 2015-03-15 15:10:19 UTC 
Created attachment 299455 [details] [review]
matroskaparse: send global tags

Global tags are already being read in matroskaparse, but they are not
currently being sent.

This patch makes global tags get sent incrementally whenever new ones
are found.
Comment 5 Thiago Sousa Santos 2015-03-28 15:04:35 UTC 
Merged with the minor difference of copying the taglist for the event to keep the element's ref writable

commit af4502103678fd3775afbadb4cda88956e2bccce
Author: Ramiro Polla <ramiro.polla@collabora.co.uk>
Date:   Sat Mar 14 17:07:05 2015 +0100

    matroskaparse: send global tags
    
    Global tags are already being read in matroskaparse, but they are not
    currently being sent.
    
    This patch makes global tags get sent incrementally whenever new ones
    are found.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=746242