After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746096 - printf: handle unsigned modifier for long long
printf: handle unsigned modifier for long long
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-12 14:44 UTC by Aurélien Zanelli
Modified: 2015-03-12 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
printf: handle unsigned modifier for long long (924 bytes, patch)
2015-03-12 14:45 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2015-03-12 14:44:00 UTC 
Our internal printf (derived from glib's gnulib one) lacks the support for unsigned modifier for long long.

Test introduced by 744281 also show the issue:
gst/gstprintf.c:85:F:gstprintf:printf_I32_I64:0: 'str' (64-bit u value = -1017017724017666161) is not equal to '"64-bit u value = 17429726349691885455"' (64-bit u value = 17429726349691885455)
Comment 1 Aurélien Zanelli 2015-03-12 14:45:10 UTC 
Created attachment 299208 [details] [review]
printf: handle unsigned modifier for long long

For info this patch had also been merged in glib:
https://git.gnome.org/browse/glib/commit/?id=5b74681f5b4dd3f5fc93b82a4f706c2337d76a8d
Comment 2 Tim-Philipp Müller 2015-03-12 15:26:16 UTC 
Thanks, pushed:

commit 3da3e8df3e50d4cef1d0198aa620a9e78367d7f8
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Tue Feb 3 16:12:32 2015 +0100

    printf: handle unsigned modifier for long long
    
    Otherwise, an unsigned integer will be displayed as a signed one if we
    use internal print, ie HAVE_LONG_LONG_FORMAT is not defined.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=746096