After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745939 - funnel: modify debug message for a better debugging
funnel: modify debug message for a better debugging
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.4.5
Other Linux
: Normal minor
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-10 04:09 UTC by HoonHee Lee
Modified: 2016-01-08 19:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
funnel: modify debug message for a better debugging (1.14 KB, patch)
2015-03-10 04:10 UTC, HoonHee Lee 		needs-work Details | Review

Description HoonHee Lee 2015-03-10 04:09:56 UTC 
For a better debug, modified debug message in funnel element.
Comment 1 HoonHee Lee 2015-03-10 04:10:15 UTC 
Created attachment 298943 [details] [review]
funnel: modify debug message for a better debugging
Comment 2 HoonHee Lee 2015-03-10 04:16:29 UTC 
Dear all.

If you have enough time, please review below patches for funnel.
=> https://bugzilla.gnome.org/show_bug.cgi?id=738202
=> https://bugzilla.gnome.org/show_bug.cgi?id=741584
Comment 3 Tim-Philipp Müller 2015-03-10 09:49:06 UTC 
Comment on attachment 298943 [details] [review]
funnel: modify debug message for a better debugging

>+  GST_DEBUG_OBJECT (funnel, "received buffer %" GST_PRT_FORMAT, buffer);

Does this even compile?
Comment 4 Tim-Philipp Müller 2016-01-08 19:34:35 UTC 
Updated patch and merged the interesting change (i.e. the first chunk). For the second one, in git master the sink pad is used as log object, which IMHO makes more sense than the srcpad suggested in the patch, since the srcpad is always the same anyway, so that doesn't add any information.

commit 788938640d1945596788c331dc72c851927b7595
Author: HoonHee Lee <hoonhee.lee@lge.com>
Date:   Tue Mar 10 13:07:18 2015 +0900

    funnel: improve debug message
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745939

commit 4febebb9628caee41e4a56f2e46383b143421f94
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Fri Jan 8 19:25:24 2016 +0000

    info: add buffer list support to GST_PTR_FORMAT