After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745936 - m4: gst-args: add macro to enable or disable plugins in build time
m4: gst-args: add macro to enable or disable plugins in build time
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: common
1.4.5
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-10 02:41 UTC by HoonHee Lee
Modified: 2018-01-23 00:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
m4: gst-args: add macro to enable or disable plugins in build time (3.54 KB, patch)
2015-03-10 02:41 UTC, HoonHee Lee
none Details | Review
m4: gst-args: add macro to enable or disable plugins in build time (3.53 KB, patch)
2015-03-10 03:24 UTC, HoonHee Lee
none Details | Review

Description HoonHee Lee 2015-03-10 02:41:55 UTC
Created attachment 298941 [details] [review]
m4: gst-args: add macro to enable or disable plugins in  build time

Dear all.

Let me explain my situation.
In our company's target, most environments want to disable a plugin in build time.
But, only one wants to enable to it.
And now we are using AG_GST_CHECK_PLUGIN macro.
Currently situation, for example, 99 environments may have a configure's option in such"--disable-plugin".
I think it is a little bit inefficiently.

Thus I expand AG_GST_CHECK_PLUGIN macro to enable or disable plugin as default.
As you know, AG_GST_CHECK_PLUGIN has a default value to enable plugin.
Thus, this expanded macro may useful and it is reasonable to assume that give degree of freedom to each target environments.
Comment 1 HoonHee Lee 2015-03-10 02:42:20 UTC
If there is a good approach or idea, please let me know.
Comment 2 HoonHee Lee 2015-03-10 03:24:37 UTC
Created attachment 298942 [details] [review]
m4: gst-args: add macro to enable or disable plugins in build time
Comment 3 HoonHee Lee 2015-03-12 05:16:55 UTC
Dear all
Please review this patch.
Comment 4 Tim-Philipp Müller 2015-03-12 10:15:29 UTC
Please be patient. This has been submitted only recently.
Comment 5 Tim-Philipp Müller 2015-03-12 12:44:57 UTC
Could you elaborate how and where this new m4 macro would be used?

Is it for use in third party plugin modules? If yes, why does it need to be included in GStreamer's common m4 files?
Comment 6 HoonHee Lee 2015-03-13 04:19:11 UTC
I would like to say that sorry for my hot temper.
And thanks for your comment.

Expanded AG_GST_CHECK_PLUGIN macro used for 3rd party.
Comment 7 Jan Schmidt 2015-03-14 12:43:08 UTC
Rather than a new macro that is almost the same as AG_GST_CHECK_PLUGIN, I think we could just make AG_GST_CHECK_PLUGIN take an optional 2nd argument to say if the plugin is enabled/disabled by default, with the default being the current (enabled) behaviour if the argument is omitted.
Comment 8 HoonHee Lee 2015-03-14 13:06:14 UTC
Thanks for your comment.
I agree with your opinion.
For example, AG_GST_CHECK_PLUGIN(foo,disable) is right? if i want to disable by default.
Comment 9 HoonHee Lee 2015-03-14 13:07:18 UTC
That is what I want to do.
Comment 10 Jan Schmidt 2015-03-14 13:17:26 UTC
Yes, exactly like that.
Comment 11 Tim-Philipp Müller 2018-01-23 00:49:20 UTC
Closing this for lack of inactivity to reduce clutter in bugzilla.

Also, we're moving towards Meson and will drop Autotools sooner or later, so not really worth keeping this open in my opinion.