GNOME Bugzilla – Bug 745936
m4: gst-args: add macro to enable or disable plugins in build time
Last modified: 2018-01-23 00:49:20 UTC
Created attachment 298941 [details] [review] m4: gst-args: add macro to enable or disable plugins in build time Dear all. Let me explain my situation. In our company's target, most environments want to disable a plugin in build time. But, only one wants to enable to it. And now we are using AG_GST_CHECK_PLUGIN macro. Currently situation, for example, 99 environments may have a configure's option in such"--disable-plugin". I think it is a little bit inefficiently. Thus I expand AG_GST_CHECK_PLUGIN macro to enable or disable plugin as default. As you know, AG_GST_CHECK_PLUGIN has a default value to enable plugin. Thus, this expanded macro may useful and it is reasonable to assume that give degree of freedom to each target environments.
If there is a good approach or idea, please let me know.
Created attachment 298942 [details] [review] m4: gst-args: add macro to enable or disable plugins in build time
Dear all Please review this patch.
Please be patient. This has been submitted only recently.
Could you elaborate how and where this new m4 macro would be used? Is it for use in third party plugin modules? If yes, why does it need to be included in GStreamer's common m4 files?
I would like to say that sorry for my hot temper. And thanks for your comment. Expanded AG_GST_CHECK_PLUGIN macro used for 3rd party.
Rather than a new macro that is almost the same as AG_GST_CHECK_PLUGIN, I think we could just make AG_GST_CHECK_PLUGIN take an optional 2nd argument to say if the plugin is enabled/disabled by default, with the default being the current (enabled) behaviour if the argument is omitted.
Thanks for your comment. I agree with your opinion. For example, AG_GST_CHECK_PLUGIN(foo,disable) is right? if i want to disable by default.
That is what I want to do.
Yes, exactly like that.
Closing this for lack of inactivity to reduce clutter in bugzilla. Also, we're moving towards Meson and will drop Autotools sooner or later, so not really worth keeping this open in my opinion.