After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745868 - gdm does not start if /etc/default/locale does not exist, since #745286 was fixed
gdm does not start if /etc/default/locale does not exist, since #745286 was f...
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-09 00:08 UTC by Simon McVittie
Modified: 2015-03-09 21:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
systemd: don't require lang file to exist (1.64 KB, patch)
2015-03-09 16:56 UTC, Ray Strode [halfline]
none Details | Review

Description Simon McVittie 2015-03-09 00:08:46 UTC
Forwarding Josh Triplett's bug report from <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779989>; for context, we cherry-picked the patch from Bug #745286 into version 3.14.1-4.

> Setting up gdm3 (3.14.1-4) ...
> Job for gdm.service failed. See 'systemctl status gdm.service' and
> 'journalctl -xn' for details.
> invoke-rc.d: initscript gdm3, action "reload" failed.
...
> Mar 07 10:17:42 thin systemd[1]: Failed to load environment files: No such
> file or directory
> Mar 07 10:17:42 thin systemd[1]: gdm.service failed to run 'reload' task: No
> such file or directory
...
> Turns out this actually prevents gdm from starting at all, rather than
> just breaking reload.  When I next booted my system, it stayed in text
> mode and failed to start gdm.

The fix to gdm.service is trivial:

-EnvironmentFile=@LANG_CONFIG_FILE@
+EnvironmentFile=-@LANG_CONFIG_FILE@

(The leading - means "ignore if nonexistent", like -include in GNU make.)
Comment 1 Ray Strode [halfline] 2015-03-09 16:56:58 UTC
Created attachment 298901 [details] [review]
systemd: don't require lang file to exist

commit fbb922cfcf4e389b0aa416d9a81c45f8f938f104 made sure
to source /etc/default/locale on debian so that GDM gets
started with the correct locale.

Unfortunately, now if that file doesn't exist (which is entirely
legitimate) then GDM won't start.

This commit makes sure to still start GDM, even if the file couldn't
be sourced.
Comment 2 Matthias Clasen 2015-03-09 21:13:44 UTC
this was pushed
Comment 3 Ray Strode [halfline] 2015-03-09 21:48:26 UTC
indeed, i keep running into machines with old versions of git-bz installed that don't add the push messages with new bugzilla.