GNOME Bugzilla – Bug 745714
Bad SSCS indention, dont let Shell theme build on several compilers/rules
Last modified: 2015-03-06 11:44:35 UTC
Created attachment 298671 [details] [review] Fix indention This patch fixes the indention errors that dont let theme to build on several compilers, plus it is easier for theme author to work on it, on editors that use indention guide-lines. It is tested with sccs-lint proposed by Jimmac https://github.com/causes/scss-lint
(In reply to alex diavatis from comment #0) > This patch fixes the indention errors that dont let theme to build on > several compilers I'm pretty sure those "errors" are intentional structuring of the file that makes life easier for our designers. I'm afraid that takes precedence over any compatibility with compilers we don't use or someone else's editor preference ... The final decision is up to the designers of course, but I suspect that we will reject this patch.
(In reply to Florian Müllner from comment #1) > (In reply to alex diavatis from comment #0) > > This patch fixes the indention errors that dont let theme to build on > > several compilers > > I'm pretty sure those "errors" are intentional structuring of the file that > makes life easier for our designers. I'm afraid that takes precedence over > any compatibility with compilers we don't use or someone else's editor > preference ... > The final decision is up to the designers of course, but I suspect that we > will reject this patch. I noticed that some indentation seems to be "intentional" (others are just typos though) so designers can recognize blocks, but those "blocks" may be on separate files. The theme is confusing for people who want to fork it, and we can improve it. In any case it has syntax errors.
(In reply to alex diavatis from comment #2) > The theme is confusing for people who want to fork it, and we can improve > it. Creating alternative themes for gnome-shell is possible because it's free software, but having many (or for what it's worth: any) 3rd party themes is not a goal we have. If changes you propose makes life easier for our designers, then great. But if we have to choose between their comfort or that of "people who want to fork it", the former will win. Also not sure what you mean by syntax errors - if I run "git diff -w" against your patch, I only see a couple of added/removed empty lines. If you mean "scss-lint's default configuration assumes a different indentation style" then meh - good luck telling Linus that the kernel is full of errors because it does not follow GNU coding standards ...
(In reply to Florian Müllner from comment #3) > (In reply to alex diavatis from comment #2) > > The theme is confusing for people who want to fork it, and we can improve > > it. > > Creating alternative themes for gnome-shell is possible because it's free > software, but having many (or for what it's worth: any) 3rd party themes is > not a goal we have. If changes you propose makes life easier for our > designers, then great. But if we have to choose between their comfort or > that of "people who want to fork it", the former will win. By fork I mean people that want to contribute online, they cannot. Shell Theme is "manageable", but the GTK theme is totally impossible to contribute, if you don't follow standard SSCS/CSS guidelines. > > Also not sure what you mean by syntax errors - if I run "git diff -w" > against your patch, I only see a couple of added/removed empty lines. No, I didnt remove/add any lines, I fixed the indentations, that was more than 1000. > If you > mean "scss-lint's default configuration assumes a different indentation > style" then meh - good luck telling Linus that the kernel is full of errors > because it does not follow GNU coding standards ... What I mean is that it doesn't sound right to have a 3000lines CSS with 3000 warnings on any compiler. And Linus is Linus :) Anyway, I don't insist, I just do think is a good idea to have properly written stylesheets, coz contributors change from time to time.
Created attachment 298694 [details] [review] theme: fix indentation - conform to 2 spaces consistently
I've fixed the clear indentation errors cause by copy & paste. However I maintain the point I made on IRC that the indentation does help to structure the code, doesn't actually raise scss-lint errors. There is still a sea of warnings we get due to shell not being a web page. I hope you don't see this as a way of making 3rd party themer a harder job and see the benefit from our point of view. As I've mentioned on IRC we will hopefully structure the elements better and make use of the actual *cascading* bit so we won't have to treat all elements as siblings. Then the actual structure won't need us to indent siblings. Attachment 298694 [details] pushed as 3e491cc - theme: fix indentation
(In reply to Jakub Steiner from comment #6) > I hope you don't see this as a way of making 3rd party themer a harder job > and see the benefit from our point of view. As I've mentioned on IRC we will > hopefully > structure the elements better and make use of the actual *cascading* bit so > we won't > have to treat all elements as siblings. Then the actual structure won't need > us to indent > siblings. Hey, I understand how hard is what you're doing with the stylesheets (I can clearly can see it now I'm working on it!) and I see the time and energy you spend for making better visuals in general(on GTK, Shell, Icons, fonts, etc). I just feel you (as GNOME) have a big project here and you can "push" it accordingly. Even if at this point you don't care about third party themes, I think it will make everyone's life easier (including yours) if you're going to "standardize" things as other project do. In fact, I do think this way you can find more contributors. Please don't interpret that as a personal request. I do believe things could be "better" with less effort.