GNOME Bugzilla – Bug 745586
rtpsession: Implement RFC 2762
Last modified: 2018-11-03 14:58:18 UTC
Created attachment 298511 [details] [review] patch generated using git format-patch rtpsession declares an array of maps to store srrcs but only the the key 0 is being used. This patch replaces the array of maps for just one map and remove useless parameters in rtpsession
It's the beginning of an implementation of RFC 2762, which is needed for large multicast groups. The implementation is not yet complete but why not leave what is there and implement RFC 2762 instead?
commit 1591adf4cd843d13d8622a30c619425691a84128 Author: Santiago Carot-Nemesio <sancane@gmail.com> Date: Wed Mar 4 10:35:12 2015 +0100 rtpsession: Do not use an array of maps if they are not being used rtpsession declares an array of maps to store srrcs but only the the key 0 is being used. This patch replaces the array of maps for just one map and remove useless parameters in rtpsession https://bugzilla.gnome.org/show_bug.cgi?id=745586
I'm not very familiarizated with that RFC, but as far as I concerned that's just an experimental protocol, not a mature standard. I was just curious to see why such an array of maps was there if it was not being used anywhere. I saw that the code was not touched since 2007 so I thought it was a waste of resources result of a refactorization or something along that lines. That is the reason why I submitted this patch.
commit 8984e18ef778c398c986fd8d9df72bfb819d34c7 Author: Sebastian Dröge <sebastian@centricular.com> Date: Wed Mar 4 11:28:12 2015 +0100 rtpsession: Add explanation why we have space for 32 hash tables And also create only one, there's no need yet to create all 32 until we implement RFC2762. commit af2bdd6e158b6e54f083994b557c458e5aca0faf Author: Sebastian Dröge <sebastian@centricular.com> Date: Wed Mar 4 11:26:57 2015 +0100 Revert "rtpsession: Do not use an array of maps if they are not being used" This reverts commit 1591adf4cd843d13d8622a30c619425691a84128. https://bugzilla.gnome.org/show_bug.cgi?id=745586#c1: It's the beginning of an implementation of RFC 2762, which is needed for large multicast groups. The implementation is not yet complete but why not leave what is there and implement RFC 2762 instead?
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/164.