After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745585 - aacparse: LOAS parsing issue with malformed data
aacparse: LOAS parsing issue with malformed data
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.4.5
Other All
: Normal normal
: 1.4.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-04 09:38 UTC by Nicolas Huet
Modified: 2015-03-06 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix LOAS parsing issue patch (941 bytes, patch)
2015-03-04 09:38 UTC, Nicolas Huet 		committed Details | Review
aac gdp file (1.55 MB, application/octet-stream)
2015-03-04 09:48 UTC, Nicolas Huet 		  Details

Description Nicolas Huet 2015-03-04 09:38:25 UTC 
Created attachment 298509 [details] [review]
fix LOAS parsing issue patch

In the function gst_aac_parse_detect_stream when parsing LOAS, the variable i is ignored at line 812.

The expected duration for aac.gdp is about 5 min.

Test command is:
gst-launch-1.0 -v filesrc location=aac.gdp ! gdpdepay ! aacparse ! fakesink silent=false

Without the patch the last buffer is:
(fakesink0:sink) (330 bytes, dts: 0:02:20.272265074, pts: 0:02:20.570931736, duration: 0:00:00.042666666, offset: 900902, offset_end: -1, flags: 00000000 ) 0x75405b80

With the patch:
(fakesink0:sink) (310 bytes, dts: 0:04:53.872265074, pts: 0:04:54.042931738, duration: 0:00:00.042666666, offset: 2029827, offset_end: -1, flags: 00000000 ) 0x75405d60
Comment 1 Nicolas Huet 2015-03-04 09:48:41 UTC 
Created attachment 298512 [details]
aac gdp file

The duration is 4min only
Comment 2 Thiago Sousa Santos 2015-03-06 17:53:18 UTC 
The git master doesn't show this issue, perhaps you attached the wrong gdp file?

Anyway your patch makes sense. Thanks for the fix.

commit 5ead23a14a1b85e785d5ba0a3327764c6479afc9
Author: Nicolas Huet <nicolas.huet@parrot.com>
Date:   Wed Mar 4 10:27:17 2015 +0100

    aacparse: fix LOAS parsing issue
    
    Fix missing index in syncword searching
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745585
Comment 3 Thiago Sousa Santos 2015-03-06 18:02:10 UTC 
Also in 1.4 branch, will be available in the 1.4.6 release:

Commit 327515a35f03d4a315dada57cb20c97e7071718c