After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745535 - vaapipostproc: always activate buffer pool
vaapipostproc: always activate buffer pool
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 743569
 
 
Reported: 2015-03-03 15:06 UTC by Víctor Manuel Jáquez Leal
Modified: 2015-03-06 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vaapipostproc: always activate buffer pool (2.32 KB, patch)
2015-03-03 15:06 UTC, Víctor Manuel Jáquez Leal 		accepted-commit_now Details | Review

Description Víctor Manuel Jáquez Leal 2015-03-03 15:06:50 UTC 
When playing videos with gst-play using the new gstvaapidecodebin, it fails 
most of time, because normally, several caps negotiations are done and it is 
not supported by vaapipostproc.

The following patch fixes that issue.
Comment 1 Víctor Manuel Jáquez Leal 2015-03-03 15:06:56 UTC 
Created attachment 298441 [details] [review]
vaapipostproc: always activate buffer pool

The vaapipostproc has a proxy flag to know if the the buffer pool is
already active. But this fails in some situations where it is needed
to renegotiate the buffer pool.

This patch removes that flag so the renegotiation is done whenever is
required.
Comment 2 sreerenj 2015-03-03 16:02:59 UTC 
Could you please share the video sample?
Comment 3 Víctor Manuel Jáquez Leal 2015-03-03 16:29:35 UTC 
(In reply to sreerenj from comment #2)
> Could you please share the video sample?

The one that hadess shared in bug #743687

https://hadess.fedorapeople.org/bug743687.mkv

But I have a full motion picture that shows the same behavior.
Comment 4 Víctor Manuel Jáquez Leal 2015-03-03 16:32:18 UTC 
Though, I'm quite convinced that the proxy flag is not necessary at all: gst_buffer_pool_set_active () has a shortcut for that situation.
Comment 5 sreerenj 2015-03-06 13:23:33 UTC 
Review of attachment 298441 [details] [review]:

LGTM
Comment 6 sreerenj 2015-03-06 16:11:27 UTC 
Pushed, Thanks for the patch.
commit 98655a195fcacd649d51f1fd45c7ef9cc2d26fa3
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Fri Mar 6 12:16:17 2015 +0200

    vaapipostproc: always activate buffer pool
    
    The vaapipostproc has a proxy flag to know if the the buffer pool is
    already active. But this fails in some situations where it is needed
    to renegotiate the buffer pool.
    
    This patch removes that flag so the renegotiation is done whenever is
    required.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745535