GNOME Bugzilla – Bug 745471
Highlighting: Ctrl should matter when you click
Last modified: 2015-03-03 14:11:14 UTC
Ctrl+mouse does recrangular highlighting. Currently the state of the Ctrl modifier is checked when you start dragging with the mouse and exceed the threshold. Instead, we should read Ctrl's state when the mouse click occurs, so that the sequence Ctrl -> click -> release ctrl -> move mouse highlights in rectangular mode.
Agreed.
Created attachment 298334 [details] [review] Fix
Created attachment 298338 [details] [review] Fix v2 "extend selection" is a feature when you hold Shift and the application is not interested in mouse events. In this case we shouldn't check for Ctrl again and update the rectangular mode, as that'd result in stupid behavior and incorrect display contents (it's not visually updated to reflect the change in rect mode). So this one's the correct fix.
Description probably unclear for those who're not aware of this feature (e.g. me until a couple of days ago :)). So: Normal terminal contents, no application running that'd be interested in mouse events. Do some normal selection and totally release the mouse. The selection is there highlighted. Here with Shift+click you can continue extending that selection. And this is where we shouldn't care about Ctrl and hence my first patch was broken.
Fixed