After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745470 - Warning in launch-new-instance plugin: undeclared variable activateOriginal
Warning in launch-new-instance plugin: undeclared variable activateOriginal
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.15.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-02 16:25 UTC by Vadim Rutkovsky
Modified: 2015-03-02 20:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
launch-new-instance: Fix warning (1.01 KB, patch)
2015-03-02 20:05 UTC, Florian Müllner
committed Details | Review

Description Vadim Rutkovsky 2015-03-02 16:25:11 UTC
Shows up in the log during Gnome Classic startup

Mar 02 08:21:59 continuoustest gnome-session[575]: Gjs-Message: JS WARNING: [/usr/share/gnome-shell/extensions/launch-new-instance@gnome-shell-extensions.gcampax.github.com/extension.js 9]: assignment to undeclared variable _activateOriginal

gnome-shell-extentions 3.15.90-12-g7afdb541ce547f74f6f9aa40008f073570ecb8d7
Comment 1 Florian Müllner 2015-03-02 20:05:44 UTC
The following fix has been pushed:
c69ea80 launch-new-instance: Fix warning
Comment 2 Florian Müllner 2015-03-02 20:05:49 UTC
Created attachment 298344 [details] [review]
launch-new-instance: Fix warning

Commit 2667b9f3e58 updated the extension for a shell change that
renamed _onActivate() to _activate, but forgot to also rename the
declaration of the variable that stores the original function.
Fix this to stop a warning about assignment to an undefined variable.