GNOME Bugzilla – Bug 745460
media-factory: complete DSCP QoS setting support
Last modified: 2018-11-03 15:38:20 UTC
Buffer size set at media factory level is not applied down to UDP sink. This can be easily verified by running one of the sample tests: * with GST_DEBUG="multiudpsink:7" * modified to use gst_rtsp_media_factory_set_buffer_size() * with suitable permissions. Moreover, it is not possible to configure the DSCP/QoS field of UDP sinks neither at the media factory level nor at the media level. Althought it is possible for an application to set this using gst_rtsp_stream_set_dscp_qos() at media-configure time, an additional handy "gst_rtsp_media_factory_set_dscp_qos()" method would be more consistent with the overall factory/media/stream API.
Created attachment 298305 [details] [review] rtsp-media: propagate buffer size down to sinks Apply media buffer size settings to related streams for RTP data only outgoing sockets, i.e., not onto RTCP related sinks.
Created attachment 298434 [details] [review] rtsp-media: propagate buffer size down to sinks Apply media buffer size settings to related streams for RTP data only outgoing sockets, i.e., not onto RTCP related sinks.
Created attachment 298435 [details] [review] media-factory: complete DSCP QoS setting support add dscp_qos setting support at factory and media level to setup IP DSCP field of bounded UDP sinks.
Comment on attachment 298434 [details] [review] rtsp-media: propagate buffer size down to sinks Looks like this has been fixed independently with #749095, sorry.
Retitling to reflect remaining issue/patch.
Comment on attachment 298435 [details] [review] media-factory: complete DSCP QoS setting support Looks good but does not apply to latest GIT master. Please rebase :)
Ping?
Created attachment 321372 [details] [review] media-factory: complete DSCP QoS setting support add dscp_qos setting support at factory and media level to setup IP DSCP field of bounded UDP sinks.
Sorry for the late answer, patch rebased but needs testing as I have no up to date gstreamer build at the present time (unless you can afford waiting for next week...) Regards
No need to hurry, let's wait until you tested it then :) Please let us know
(In reply to Sebastian Dröge (slomo) from comment #10) > No need to hurry, let's wait until you tested it then :) Please let us know Perfect. I come back to you next week ;)
Gregor, did you ever get around to testing this?
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-rtsp-server/issues/6.