Created attachment 298405 [details] [review]
legacyTray: Add a hideable tray for legacy status icons

This implements Jakub's mockup - Allan suggested to move it to the other side, I'll attach that as a separate patch on top of this one, so that we can try out both ...

Created attachment 298406 [details] [review]
legacyTray: Move to the left ...

... as suggested by Allan.

Created attachment 298439 [details] [review]
legacyTray: Add a hideable tray for legacy status icons

So the left it is - squashed both patches and did some minor style tweaks.

Review of attachment 298439 [details] [review]:

::: js/ui/legacyTray.js
@@ +94,3 @@
+                Tweener.removeTweens(this._slider);
+                Tweener.addTween(this._slider, { opacity: 0,
+                                               time: Overview.ANIMATION_TIME,

space missing

@@ +95,3 @@
+                Tweener.addTween(this._slider, { opacity: 0,
+                                               time: Overview.ANIMATION_TIME,
+                                               transition: 'easeOutQuad' });

dito

@@ +103,3 @@
+                Tweener.removeTweens(this._slider);
+                Tweener.addTween(this._slider, { opacity: 255,
+                                               time: Overview.ANIMATION_TIME,

dito

@@ +104,3 @@
+                Tweener.addTween(this._slider, { opacity: 255,
+                                               time: Overview.ANIMATION_TIME,
+                                               transition: 'easeOutQuad' });

dito

@@ +157,3 @@
+
+        if (!this.actor.visible)
+            return;

Can't we have here some weird slide animation if we don't set the slideX value always?
Like actor visible, conceal handle not visible, so it animates from a invalid position calculated before to the new correct one (althought this can't happen probably, just an example). Or some weird couple of things together that could put it in a weird state...

I remember having some issues with the dash etc because of inconsistency on the slide position... so just to make sure we could slideX = 0 here.

Feel free to ignore if you are sure.

Created attachment 298458 [details] [review]
legacyTray: Add a hideable tray for legacy status icons

(In reply to Carlos Soriano from comment #4)
> +                                               time:
> Overview.ANIMATION_TIME,
> 
> space missing

Ah yeah - used to be "this.actor" and I forgot to reindent when changing it. Fixed.


> @@ +157,3 @@
> +
> +        if (!this.actor.visible)
> +            return;
> 
> Can't we have here some weird slide animation if we don't set the slideX
> value always?

Probably not, at least I didn't encounter anything in testing. Still, here's a version that does less special-casing, just to be safe ...

Review of attachment 298458 [details] [review]:

Yep! Thanks!

Attachment 298458 [details] pushed as 874cf0b - legacyTray: Add a hideable tray for legacy status icons

Hi,

I have a double screen configuration with primary on right.
My concerns are :

- I don't like having this on my screen because it can mask part of my apps
- Even without icons on it and so no tray shown, there's still a pointer barrier

Current design doesn't solve problems, and make new ones, can we please have this fixed? 
I think the best solution while legacy icons are still needed is already available, you just need to include it. 
https://extensions.gnome.org/extension/495/topicons/ 

Extensions are good, but they can break you system, and for something like this, it should be included by default.

Created attachment 300524 [details]
new systray over windows, blocking content

(In reply to (bitlord) from comment #10)
> Created attachment 300524 [details]
> new systray over windows, blocking content

That issue is covered by bug 746787 - let's deal with it there.

(In reply to Florian Müllner from comment #1)
> Created attachment 298405 [details] [review] [review]
> legacyTray: Add a hideable tray for legacy status icons
> 
> This implements Jakub's mockup - Allan suggested to move it to the other
> side

May I know the reason? Current tray would still hide half the character when it's hidden. And "1" or "l" could be completely hidden. I would think moving the tray to the right would make this problem go away.

(In reply to Nguyen Thai Ngoc Duy from comment #12)
> (In reply to Florian Müllner from comment #1)
> > This implements Jakub's mockup - Allan suggested to move it to the other
> > side
> 
> May I know the reason?

The right side is more likely to interfere with controls (scrollbar steppers come to mind). Not all windows are terminals :-)

(In reply to Florian Müllner from comment #13)
> (In reply to Nguyen Thai Ngoc Duy from comment #12)
> > (In reply to Florian Müllner from comment #1)
> > > This implements Jakub's mockup - Allan suggested to move it to the other
> > > side
> > 
> > May I know the reason?
> 
> The right side is more likely to interfere with controls (scrollbar steppers
> come to mind). Not all windows are terminals :-)

Right. Makes sense. It's still annoying for terminal users though. Perhaps making the strip a circle and sticking it at the left bottom (so only a quarter of the circle shows up) will be better? Discoverability is already pretty good when the legacy tray temporarily shows up when new icons are added.