After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745132 - The timestamp in ongoing messages not updated
The timestamp in ongoing messages not updated
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 745111
Blocks:
 
 
Reported: 2015-02-24 22:58 UTC by Yosef Or Boczko
Modified: 2015-03-04 12:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
calendar: Update notification timestamps/positions on updates (3.97 KB, patch)
2015-02-25 23:48 UTC, Florian Müllner
committed Details | Review

Description Yosef Or Boczko 2015-02-24 22:58:27 UTC
I'm listening to some music in a playlist.

When the first sogn start played, I get message with
the current time. 4 minutes after the next song come
and the message replaced (I didn't closed/remoced/clean
the message before), the whole content are changed exept
the timesmap. after an houre I'll see the same time when
I started to played the playlist.

The timestamp had to be updated.
Comment 1 Allan Day 2015-02-25 14:55:38 UTC
I think I agree with the report - the timestamp should reflect when the notification was last updated.
Comment 2 Florian Müllner 2015-02-25 15:24:35 UTC
Should the notification also move up the list again?
Comment 3 Allan Day 2015-02-25 16:16:01 UTC
(In reply to Florian Müllner from comment #2)
> Should the notification also move up the list again?

That's the implication, I suppose.

Note that music isn't really a good example here, since it is a fairly unique kind of operation. A better example would be something like mail - a notification like "8 new mails" which gets updated to "12 new mails" should reflect the time of the update, both with the timestamp and the position in the list.
Comment 4 Florian Müllner 2015-02-25 23:48:34 UTC
Created attachment 297937 [details] [review]
calendar: Update notification timestamps/positions on updates

Currently both the timestamp and the position in the notification list
are static once a notification has been added; however notifications may
be updated later, in which case those properties should be reevaluated.
Comment 5 drago01 2015-03-04 12:04:57 UTC
Review of attachment 297937 [details] [review]:

Looks good.
Comment 6 Florian Müllner 2015-03-04 12:58:09 UTC
Attachment 297937 [details] pushed as 39a57ee - calendar: Update notification timestamps/positions on updates