After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745025 - Context.has_scores() is no longer usable
Context.has_scores() is no longer usable
Status: RESOLVED FIXED
Product: libgnome-games-support
Classification: Other
Component: general
unspecified
Other Linux
: High blocker
: ---
Assigned To: Michael Catanzaro
libgames-scores maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-23 15:22 UTC by Michael Catanzaro
Modified: 2015-03-03 23:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Load scores in has_scores() (1014 bytes, patch)
2015-03-03 20:53 UTC, Juan R. Garcia Blanco
none Details | Review

Description Michael Catanzaro 2015-02-23 15:22:18 UTC
We had to stop loading scores during Context creation, which I started doing yesterday, because the user has to first create the context to connect to the category-request signal before loading can work. (We used to have documentation on this but I think it was in the TODO file so got deleted.) This means the game can no longer use Context.has_score(), which we added yesterday, to figure out whether the scores dialog should be sensitive or not. We need to load scores when that function is called. We might even warn if scores are loaded in any other situation.
Comment 1 Juan R. Garcia Blanco 2015-03-03 20:53:24 UTC
Created attachment 298484 [details] [review]
Load scores in has_scores()

Wouldn't this be enough? I'm not very familiar with the library.
Comment 2 Michael Catanzaro 2015-03-03 23:21:19 UTC
Yeah, that should work. It was not a very hard problem. :D