After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744928 - src/application_window.c: void function should not return a value
src/application_window.c: void function should not return a value
Status: RESOLVED FIXED
Product: easytag
Classification: Other
Component: general
master
Other FreeBSD
: Normal normal
: 2.2
Assigned To: EasyTAG maintainer(s)
EasyTAG maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-22 04:56 UTC by Ting-Wei Lan
Modified: 2015-02-22 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix "void function should not return a value" (934 bytes, patch)
2015-02-22 04:57 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2015-02-22 04:56:28 UTC 
et_application_window_update_file_name_from_ui doesn't have a return value, so it should use g_return_if_fail instead of g_return_val_if_fail. This causes error when compiling easytag with clang.

The attached patch fixes this error.
Comment 1 Ting-Wei Lan 2015-02-22 04:57:31 UTC 
Created attachment 297551 [details] [review]
Fix "void function should not return a value"
Comment 2 David King 2015-02-22 09:50:59 UTC 
Review of attachment 297551 [details] [review]:

Looks good, please push.
Comment 3 Ting-Wei Lan 2015-02-22 15:24:30 UTC 
Comment on attachment 297551 [details] [review]
Fix "void function should not return a value"

Attachment 297551 [details] pushed as 678d0b9 - Fix "void function should not return a value"
Comment 4 David King 2015-02-22 15:31:25 UTC 
Thanks, much appreciated!