GNOME Bugzilla – Bug 744900
Theme: Too many values for border-radius property
Last modified: 2015-02-22 14:02:54 UTC
Too many values for border-radius property. GNOME Shell throws the following warning message '(gnome-shell:4603): St-WARNING **: Too many values for border-radius property.' This is due a typo 'border-radius' property in two clases of the theme style gnome-shell.css and gnome-shell-high-contrast.css files.
The attached patch fixes the bug. Was fixed with just remove the last '0' on the 'border-radius' property in the '.tile-preview-left.on-primary' class.
Created attachment 297509 [details] [review] Too many values for border-radius property.
Review of attachment 297509 [details] [review]: Both gnome-shell.css and gnome-shell-high-contrast.css are now generated. The sources are in the gnome-shell-sass submodule (in data/theme/gnome-shell-sass), _common.scss in particular. You should do a patch against that file, then we can regenerate the CSS.
Created attachment 297512 [details] [review] Theme: Too many values for border-radius property. OK, so I went ahead and pushed your change to the gnome-shell-sass repo: https://git.gnome.org/browse/gnome-shell-sass/commit/?id=1087927ea0ae Reattaching your change with the generated file (note that a submodule update is now part of the patch). Thanks for your attention to detail!
Attachment 297512 [details] pushed as 7d2690a - Theme: Too many values for border-radius property.
(In reply to Florian Müllner from comment #3) > Review of attachment 297509 [details] [review] [review]: > > Both gnome-shell.css and gnome-shell-high-contrast.css are now generated. > The sources are in the gnome-shell-sass submodule (in > data/theme/gnome-shell-sass), _common.scss in particular. You should do a > patch against that file, then we can regenerate the CSS. Ok, sorry for the inconvenience I was not sure about that. Thank you for the info. BTW, what about this[1] repo? It is a parallel development? [1] https://git.gnome.org/browse/gnome-shell-sass/
(In reply to Florian Müllner from comment #4) > Created attachment 297512 [details] [review] [review] > Theme: Too many values for border-radius property. > > OK, so I went ahead and pushed your change to the gnome-shell-sass repo: > > https://git.gnome.org/browse/gnome-shell-sass/commit/?id=1087927ea0ae > > Reattaching your change with the generated file (note that a submodule > update is now part of the patch). > > Thanks for your attention to detail! A pleasure. :)
(In reply to Miguel Vaello Martínez from comment #6) > BTW, what about this[1] repo? It is a parallel development? > > [1] https://git.gnome.org/browse/gnome-shell-sass/ Not sure what you mean by "parallel development". It's a module that was created to allow sharing the style sources between gnome-shell and gnome-shell-extensions (which provides the style for the GNOME classic session) - both import it as git submodule into their tree.
(In reply to Florian Müllner from comment #8) > (In reply to Miguel Vaello Martínez from comment #6) > > BTW, what about this[1] repo? It is a parallel development? > > > > [1] https://git.gnome.org/browse/gnome-shell-sass/ > > Not sure what you mean by "parallel development". It's a module that was > created to allow sharing the style sources between gnome-shell and > gnome-shell-extensions (which provides the style for the GNOME classic > session) - both import it as git submodule into their tree. Ok, I was a little confused, sorry. This morning I was checking deeper the repo I realized that the gnome-shell contains the mentioned submodule.