After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744872 - New high score only stored after hitting Enter
New high score only stored after hitting Enter
Status: RESOLVED FIXED
Product: libgnome-games-support
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Michael Catanzaro
libgames-scores maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-20 22:11 UTC by Juan R. Garcia Blanco
Modified: 2015-02-22 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
scores: Save scores after running the dialog (1.67 KB, patch)
2015-02-22 19:19 UTC, Michael Catanzaro
none Details | Review

Description Juan R. Garcia Blanco 2015-02-20 22:11:13 UTC
When a new high score is achieved, the scores dialog is automatically shown. If you click "Done", and run the dialog again, you will see the new high score; however, it is not saved to disk.

When the new high score dialog shows up, if you hit Enter key, as if you agreed with the name, the new score is saved to disk. In fact, it is saved as many times as you hit the Enter key. However, if you run again the dialog, you will only see one entry (i.e. duplicates seem to be removed).
Comment 1 Michael Catanzaro 2015-02-22 18:33:15 UTC
Arnaud, I will fix this; I am on a roll today.
Comment 2 Michael Catanzaro 2015-02-22 19:19:27 UTC
The following fix has been pushed:
5c0ea59 scores: Save scores after running the dialog
Comment 3 Michael Catanzaro 2015-02-22 19:19:30 UTC
Created attachment 297594 [details] [review]
scores: Save scores after running the dialog