After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744807 - Last song on album view keeps repeating in "mix/no repeat" mode
Last song on album view keeps repeating in "mix/no repeat" mode
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.15.x
Other Linux
: High normal
: 3.16
Assigned To: gnome-music-maint
gnome-music-maint
: 747197 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-02-19 17:49 UTC by Eddy Castillo
Modified: 2015-08-04 09:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Playing last song of album with gnome-music (106.33 KB, video/webm)
2015-02-19 17:49 UTC, Eddy Castillo
  Details
Always set correct nextTrack (1.01 KB, patch)
2015-08-02 22:06 UTC, Jan-Michael Brummer
committed Details | Review

Description Eddy Castillo 2015-02-19 17:49:38 UTC
Created attachment 297291 [details]
Playing last song of album with gnome-music

When playing an album in "mix/no repeat" mode, the last song keeps playing in a loop.

To reproduce:
1. Enter any album in album view.
2. Set "Mix/no repeat" mode.
3. Play the first song, and hit next until the last song.
4. Move position to end of the song.

Result: Last song repeats.
Expected: End last song and stop playing.
Comment 1 Vadim Rutkovsky 2015-03-01 15:13:02 UTC
Can't reproduce this one since https://git.gnome.org/browse/gnome-music/commit/?id=c1a60c5 at least
Comment 2 Vadim Rutkovsky 2015-04-13 09:15:58 UTC
*** Bug 747197 has been marked as a duplicate of this bug. ***
Comment 3 Vadim Rutkovsky 2015-04-13 09:16:14 UTC
Still happens on 3.16/master
Comment 4 Jan-Michael Brummer 2015-04-13 17:37:00 UTC
That's why i've opened #747197 and reported it for 3.16/master. Can someone please reopen this ticket?
Comment 5 kalexort 2015-05-15 06:34:29 UTC
Still happens on 3.16.1 (on Arch Linux).
Comment 6 Romain Failliot 2015-05-17 16:39:51 UTC
Still happens on 3.16.2 (on Manjaro)
Comment 7 kalexort 2015-05-21 05:21:45 UTC
What also happens for me almost each time I let an album play for too long and its last song is repeated, that when I go back to the Albums overview about 1 in 3 on the albums are shown without their album art. Just with a white tile.

It seems random for which albums this happens.

Perhaps this is unrelated; before the "repeat last song" bug on 3.16 this used to happen at least also with 3.12 randomly.

What can I do to help diagnose the root cause?
Comment 8 Jan-Michael Brummer 2015-08-02 22:06:12 UTC
Created attachment 308639 [details] [review]
Always set correct nextTrack

The commited patch fixes the issue. Otherwise the nextTrack wouldn't be update for the last track in playlist leading to repeating the 'previous' nextTrack.
Comment 9 Vadim Rutkovsky 2015-08-04 09:02:50 UTC
Review of attachment 308639 [details] [review]:

Thanks, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=418e810 to master
Comment 10 Vadim Rutkovsky 2015-08-04 09:09:40 UTC
Pushed https://git.gnome.org/browse/gnome-music/commit/?id=7c19e56 to gnome-3-16 branch, will appear in 3.16.2 release