After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744800 - VT switch doesn't work on gdm-3.15.90
VT switch doesn't work on gdm-3.15.90
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
: 745413 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-02-19 16:19 UTC by Armin K.
Modified: 2015-03-02 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdm: allow user to switch VTs using ctrl-alt-f[1-7] (6.98 KB, patch)
2015-02-19 19:44 UTC, Ray Strode [halfline]
needs-work Details | Review
gdm: allow user to switch VTs using ctrl-alt-f[1-7] (5.05 KB, patch)
2015-02-19 19:51 UTC, Ray Strode [halfline]
none Details | Review
wayland: add keybindings for VT8-VT12 (7.18 KB, patch)
2015-02-19 21:43 UTC, Ray Strode [halfline]
none Details | Review
gdm: allow user to switch VTs 8 through 12 (4.99 KB, patch)
2015-02-19 21:44 UTC, Ray Strode [halfline]
none Details | Review

Description Armin K. 2015-02-19 16:19:33 UTC
Since switching to a wayland based gdm greeter, vt switch doesn't work anymore from gdm. Works from gnome-shell wayland session though.
Comment 1 Ray Strode [halfline] 2015-02-19 19:44:31 UTC
Looks like the keybindings need to be whitelisted.  They work in a normal session because of this code:

        // There's little sense in implementing a keybinding in mutter and•
        // not having it work in NORMAL mode; handle this case generically•
        // so we don't have to explicitly allow all builtin keybindings in•
        // NORMAL mode.•
        if (Main.actionMode == Shell.ActionMode.NORMAL &&•
            binding.is_builtin())•
            return false;•
Comment 2 Ray Strode [halfline] 2015-02-19 19:44:59 UTC
Created attachment 297312 [details] [review]
gdm: allow user to switch VTs using ctrl-alt-f[1-7]

Users currently can't switch VTs while at the login screen.

This commit fixes that, by adding the relevant keybindings
to the login screen's allowed keybindings list.
Comment 3 Jasper St. Pierre (not reading bugmail) 2015-02-19 19:46:42 UTC
Review of attachment 297312 [details] [review]:

You should make this ActionMode.ALL instead. Users should be able to VT switch at any time.
Comment 4 Ray Strode [halfline] 2015-02-19 19:50:41 UTC
yup, makes sense. i cargoculted the wrong bits
Comment 5 Ray Strode [halfline] 2015-02-19 19:51:12 UTC
Created attachment 297313 [details] [review]
gdm: allow user to switch VTs using ctrl-alt-f[1-7]

Users currently can't switch VTs while at the login screen.

This commit fixes that, by adding the relevant keybindings
to the login screen's allowed keybindings list.
Comment 6 Ray Strode [halfline] 2015-02-19 19:51:28 UTC
Attachment 297313 [details] pushed as 5cddab3 - gdm: allow user to switch VTs using ctrl-alt-f[1-7]
Comment 7 Ray Strode [halfline] 2015-02-19 19:55:03 UTC
(i wonder why we only go up to 7 instead of 12?)
Comment 8 Jasper St. Pierre (not reading bugmail) 2015-02-19 20:11:28 UTC
Feel free to add the rest of the keybindings. I imagine it was simply laziness.
Comment 9 Ray Strode [halfline] 2015-02-19 21:43:01 UTC
Created attachment 297337 [details] [review]
wayland: add keybindings for VT8-VT12

We currently only support switching to 1-7.
This commit brings us parity with X, and let's
us switch to all 12.
Comment 10 Ray Strode [halfline] 2015-02-19 21:44:43 UTC
Created attachment 297338 [details] [review]
gdm: allow user to switch VTs 8 through 12

mutter now supports keybindings for VTs 8 through 12.

This commit makes them work from the login screen.
Comment 11 Ray Strode [halfline] 2015-02-19 21:45:15 UTC
Attachment 297338 [details] pushed as a71ab9a - gdm: allow user to switch VTs 8 through 12
Comment 12 Ray Strode [halfline] 2015-02-19 21:45:29 UTC
Attachment 297337 [details] pushed as 96b202c - wayland: add keybindings for VT8-VT12
Comment 13 Jasper St. Pierre (not reading bugmail) 2015-03-02 17:06:11 UTC
*** Bug 745413 has been marked as a duplicate of this bug. ***