After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744599 - Unable to disable draw-cursor in screencaster
Unable to disable draw-cursor in screencaster
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-16 15:58 UTC by Alexander Larsson
Modified: 2015-02-17 07:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make draw-cursor option work (1.04 KB, patch)
2015-02-16 16:00 UTC, Alexander Larsson 		accepted-commit_now Details | Review

Description Alexander Larsson 2015-02-16 15:58:49 UTC 
There is an issue for me where the screen recorder dies under wayland when reading the cursor (texture == NULL deref). I tried disabling it, but that did not work. This patch fixes the disabling.
Comment 1 Alexander Larsson 2015-02-16 16:00:23 UTC 
Created attachment 296945 [details] [review]
Make draw-cursor option work

screencast: Make it possible to disable draw-cursor

drawing cursor is on by default, so the code:
  if (options['draw-cursor'])
    recorder.set_draw_cursor(options['draw-cursor']);
never lets you unset it.

Fix is to use 'draw-cursor' in options instead.
Comment 2 Florian Müllner 2015-02-16 16:02:39 UTC 
Review of attachment 296945 [details] [review]:

Eeeks, good catch!